dev/core#389 [preliminary cleanup] Standardise metadat for custom field use
authoreileen <emcnaughton@wikimedia.org>
Thu, 30 May 2019 22:45:06 +0000 (10:45 +1200)
committereileen <emcnaughton@wikimedia.org>
Fri, 31 May 2019 01:19:41 +0000 (13:19 +1200)
commit1f61a7b1165bdf1bf45439b475b98268a44bbf57
treed73f562fe8222271fdd74f6f20e9d4983e311ff7
parentacd6c6abd5d77cc71a4e3468ec3782bc30d272e7
dev/core#389 [preliminary cleanup] Standardise metadat for custom field use

In digging into dev/core#389 I found a major complexity in fixing it was inconsistent metadata available at different
points in the code. This simply adds metadata to the 'inner-most place' & makes the BAO_CustomQuery object use that

I didn't remove the options loop because I wanted to leave that out of scope as I can't see how / if it is used
CRM/Core/BAO/CustomField.php
CRM/Core/BAO/CustomQuery.php
tests/phpunit/CRM/Core/BAO/CustomQueryTest.php