dev/event#25 Fix regression on billing name overwrite
authoreileen <emcnaughton@wikimedia.org>
Sun, 22 Dec 2019 08:53:11 +0000 (21:53 +1300)
committereileen <emcnaughton@wikimedia.org>
Sun, 22 Dec 2019 08:53:13 +0000 (21:53 +1300)
commit1a093d07385739937b999dd9160d65ef38079d20
treeba8548976a12295aa0877f3292ba05a6e7f9c6dd
parent260543f471326281c6fa972a4d07773c7bcc7bd8
dev/event#25 Fix regression on billing name overwrite

https://lab.civicrm.org/dev/event/issues/25 was caused by https://github.com/civicrm/civicrm-core/commit/b1b7f4e35bbe566d9efccac1055d311245420974
where it started overwriting the name in that function.

In digging in the code I found that it seems that as long as we call this function before the processor all is
good so we should call right before the processor rather than broader contamination.

Also note ideally the settings bag would be used.
CRM/Event/Form/Registration/Confirm.php
CRM/Event/Form/Registration/Register.php