Revert membership debug handling in IPN
authorEileen McNaughton <emcnaughton@wikimedia.org>
Tue, 11 Jan 2022 18:37:58 +0000 (07:37 +1300)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Tue, 11 Jan 2022 18:37:58 +0000 (07:37 +1300)
commit19d9044caf20d929febca79072d7f06dc94d94a4
treed4c836b7b7a872490646f6726290c039da2301d2
parent84f3dc304814cb5f8f386a20c25b294b40abf514
Revert membership debug handling in IPN

A looong time ago we added handling for the possibility of messed up memberships going through
the paypal IPN. https://github.com/civicrm/civicrm-core/pull/15053

At the time we added a lot of debug to see if it was ever hit as the handling was
an attempt to figure out a bug that we couldn't reproduce. We never got any
evidence the debug was hit or the fix helped - but
it does create a lot of code complexity and makes clean up
more difficult so
this removes it again....
CRM/Contribute/BAO/Contribution.php
CRM/Core/Payment/PayPalIPN.php
api/v3/Contribution.php
tests/phpunit/CRM/Core/Payment/PayPalIPNTest.php