APIv4 - Throw exception instead of munging illegal join aliases
authorColeman Watts <coleman@civicrm.org>
Mon, 9 Aug 2021 16:56:38 +0000 (12:56 -0400)
committerColeman Watts <coleman@civicrm.org>
Tue, 10 Aug 2021 00:01:57 +0000 (20:01 -0400)
commit1930b3e80feeaf4d8df1d1d81a19e3071b760402
treed4be9984a2257a3a27ee18ce4440d1c48845b925
parent7deeca836c5960d29a28de117decf7baba2b90c0
APIv4 - Throw exception instead of munging illegal join aliases

The problem with "fixing" an illegal join alias is that it's then mysterious
what the correct alias will be, leading to bugs when the incorrect alias
gets used throughout the rest of the api params.

Throwing an exception seems like a better way to ensure developers
are alerted to the error.
Civi/Api4/Query/Api4SelectQuery.php
tests/phpunit/api/v4/Action/FkJoinTest.php