CRM-16504 fix recurring option to show on membership renewal
authorEileen McNaughton <eileen@fuzion.co.nz>
Thu, 14 May 2015 11:59:02 +0000 (23:59 +1200)
committerEileen McNaughton <eileen@fuzion.co.nz>
Thu, 14 May 2015 11:59:46 +0000 (23:59 +1200)
commit186a737c2a94cfb96be6825afe5b44ad283eb0f5
treee225429455df504724ef346616d6cb38ea5d4461
parenta14e123a77a33879f3dd63c74b0c72031e0c8b5f
CRM-16504 fix recurring option to show on membership renewal
This patch also moves a lot of template code that is shared between the backoffice
membership renewal and the backoffice membership receipt. From what I can tell the rest of the
file could pretty much be shared code and I think there is some invoice functionality
missing from renewals as I spotted a case where there was an invoice related class
on the member form but not the renewal (that is now in the shared code)
I also found (& fixed) a situation where the amount shows for people with membership but not contribution
permissions. It is now suppressed like other contribution fields

The next step towards bringing these closer is to use the same email field name on both.

In fact the templates look for either {receipt_test_signup} or {receipt_text_renew} so
it makes sense to just set {receipt_text} - although that involves a change to the msg
template so I don't know how off-putting that is
CRM/Member/Form/Membership.php
CRM/Member/Form/MembershipRenewal.php
templates/CRM/Member/Form/Membership.tpl
templates/CRM/Member/Form/MembershipCommon.tpl [new file with mode: 0644]
templates/CRM/Member/Form/MembershipRenewal.tpl