dev/financial#69 Fix misrecording of payments against non pay_later Pending contribution.
authoreileen <emcnaughton@wikimedia.org>
Mon, 14 Oct 2019 05:20:52 +0000 (18:20 +1300)
committereileen <emcnaughton@wikimedia.org>
Mon, 14 Oct 2019 05:21:13 +0000 (18:21 +1300)
commit16b0233c2250db70e72480b3b98375168535ca7e
tree2ee953b55fb370b7076ca6b1103ccfcf3f90ee2f
parentbcc33cf71581395f8741fa03f9893519045fb164
dev/financial#69 Fix misrecording of payments against non pay_later Pending contribution.

Fixes bugs when payments are added against a non-pay later contribution. There were 2 different bugs
1) bug in form layer when the payment is fully paid
2) bug in BAO layer for partial payments.

This fixes both. It may be a regression, hence 5.19
CRM/Contribute/Form/AdditionalPayment.php
CRM/Financial/BAO/Payment.php
tests/phpunit/api/v3/PaymentTest.php