Remove isset from online contribution receipt
authorEileen McNaughton <emcnaughton@wikimedia.org>
Tue, 25 Jan 2022 03:22:21 +0000 (16:22 +1300)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Tue, 25 Jan 2022 21:30:14 +0000 (10:30 +1300)
commit132e4deafbbf57992b00bb4143fd0527b9cac732
tree4ba563d5df1e7d5f8eab7f263988065a398a8405
parent3202de203d268a3b9dbbb40e903861f7de272060
Remove isset from online contribution receipt

This removes the isset checks that re failing around
totalTaxAmount (solved the same way as offline
https://github.com/civicrm/civicrm-core/pull/22560/files#diff-fd5668d5492e5f0ec55b7f8a10eccfa4ea9de249e4cf2383a2e0d36dbd92ebe0R134
)

It also removes the isset around contribution.amount_level (switching
to a token) and the enotice on isQuickConfig - this
switches to loading that information & also using a more meaningful variable.
Note that line items should always be assigned so that check is silly.
CRM/Contribute/BAO/ContributionPage.php
CRM/Contribute/WorkflowMessage/ContributionTrait.php
tests/phpunit/api/v3/ContributionPageTest.php
tests/phpunit/api/v3/ContributionTest.php
xml/templates/message_templates/contribution_online_receipt_html.tpl
xml/templates/message_templates/contribution_online_receipt_text.tpl