[REF] Remove pass-by-reference & always empty param
authoreileen <emcnaughton@wikimedia.org>
Tue, 28 Jul 2020 21:58:18 +0000 (09:58 +1200)
committereileen <emcnaughton@wikimedia.org>
Tue, 28 Jul 2020 22:01:29 +0000 (10:01 +1200)
commit0d07fe4e35a2d2b19abf6296d5353cb092b37486
tree59f7a783356b910910dbac91fa50dc5b1e76904d
parentaa328fcee07bfe3823cc190c8b011ac5ad130fce
[REF] Remove pass-by-reference & always empty param

Once https://github.com/civicrm/civicrm-core/pull/17982 is merged there are only 2 places that call this function. In both
places
1) they instantiate an empty values array just to pass in
2) we can see they don't use input or ids afterwards, so they don't need to be passed by reference
CRM/Contribute/BAO/Contribution.php
CRM/Contribute/Form/Task/PDF.php
api/v3/Contribution.php