dev/core#1409 Remove net_amount from Addtional Payment form
authoreileen <emcnaughton@wikimedia.org>
Wed, 20 Nov 2019 04:54:22 +0000 (17:54 +1300)
committerSeamus Lee <seamuslee001@gmail.com>
Wed, 20 Nov 2019 20:23:12 +0000 (07:23 +1100)
commit0c87f9939c3c05f034ba4b896363fdb0fa7e59b6
treec2105ac280882038eb16bcfaf37f987f59bfc9ea
parenta0c08c7dd674230f340baf1e45745737e1f2d59b
dev/core#1409 Remove net_amount from Addtional Payment form

This is causing a validation problem. We used to have an issue on the contribution form which we eventually
resolved by removing net_amount as it's best calculated anyway

In order to make this changed I had to ensure Payment.create adds the net_amount & had
to do a couple of tweaks for the test to pass

Backport additional test functions and update API to get tests to pass
CRM/Contribute/Form/AdditionalPayment.php
CRM/Core/BAO/FinancialTrxn.php
api/v3/Payment.php
templates/CRM/Contribute/Form/AdditionalPayment.tpl
tests/phpunit/CiviTest/CiviUnitTestCase.php
tests/phpunit/api/v3/PaymentTest.php
tests/phpunit/api/v3/SyntaxConformanceTest.php