Make sure inherited memberships are not themselves inherited
authoreileen <emcnaughton@wikimedia.org>
Fri, 23 Aug 2019 02:43:17 +0000 (14:43 +1200)
committereileen <emcnaughton@wikimedia.org>
Tue, 27 Aug 2019 06:25:36 +0000 (18:25 +1200)
commit0a2663fd3c29cce0de5ead3a4eab9626585d9476
tree610f05447324897f6e81dc4d225e5eb90c1d835c
parent4a1dfeca8a8b4e26b3c44187c5975c7c9aafc16f
Make sure inherited memberships are not themselves inherited

In trying to make sense of the code / fix / test for https://github.com/civicrm/civicrm-core/pull/15062
I discovered the tests wouldn't pass due to a weird edge case where an individual inherited a membership
and that membership was inherited in turn via a relationship the individual had (with the same organization)

I don't believe that inheriting inherited memberships is an intentional feature & it DOEs cause issues
- this removes that possibility
CRM/Contact/BAO/Relationship.php
tests/phpunit/CRM/Contact/BAO/RelationshipTest.php