(dev/core#174) Forms/Sessions - Clear in roughly the same ways as before
authorTim Otten <totten@civicrm.org>
Thu, 28 Jun 2018 03:19:58 +0000 (20:19 -0700)
committerTim Otten <totten@civicrm.org>
Mon, 2 Jul 2018 05:08:23 +0000 (22:08 -0700)
commit0a12cd4a2a195ee89e0a2b7ba8ba457987b7f277
tree0eeaa792b498046ae2633012bef9b6170f649c65
parent19707a63a5e0ae58090803f3c7c162481515f69f
(dev/core#174) Forms/Sessions - Clear in roughly the same ways as before

In the past, if one clears the `civicrm_cache` table (i.e.  by calling
`CRM_Core_Config::clearDBCache()` ==> `TRUNCATE TABLE civicrm_cache`), then it
has the effect of destroying any active sessions/forms.

Now, in allowing sessions to be stored elsewhere, we lose that side-effect.

If we want strictly equivalent behavior (from a business-logic perspective),
then we'd want the patch to go a bit further -- calling
Civi::cache('session')->clear() at the same time that it does
`clearDBCache()`.

This revision adds `clear()` calls to various spots discussed here:

* https://docs.google.com/spreadsheets/d/1FxuIvr2noelBvhu5eja9_ps3YUWnkmGhqijBO3gH8Po/edit?usp=sharing
* https://github.com/civicrm/civicrm-core/pull/12362#issuecomment-400897782
CRM/Admin/Form/Setting.php
CRM/Admin/Form/Setting/UpdateConfigBackend.php
CRM/Core/BAO/ConfigSetting.php
CRM/Core/Config.php