Fix v4 api to do custom field delete in tearDown
authorEileen McNaughton <emcnaughton@wikimedia.org>
Thu, 15 Jul 2021 22:44:34 +0000 (10:44 +1200)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Thu, 15 Jul 2021 22:44:34 +0000 (10:44 +1200)
commit06b84fc8d5761184489e64488c75edddfad03574
treebb0e1b1bfe223961d052ef2907367d0a1c549abb
parent0a7b86717573ed909202ca4d7fa248bbad203971
Fix v4 api to do custom field delete in tearDown

This existing efforts are wrong because
1) the delete has to go in the tearDown not the clean up
2) it is rigid about the custom group table name - which
will get us into problems as the name can be set and we
should be ensuring that it can in our tests
tests/phpunit/api/v4/Action/BaseCustomValueTest.php
tests/phpunit/api/v4/Action/BasicCustomFieldTest.php