CustomField - simplify tableName lookup during bulkSave and fix bug
authorColeman Watts <coleman@civicrm.org>
Thu, 5 Nov 2020 22:36:52 +0000 (17:36 -0500)
committerColeman Watts <coleman@civicrm.org>
Thu, 5 Nov 2020 22:36:52 +0000 (17:36 -0500)
commit03e3a32ecdafcf826624b92af55ade2e66d13e89
tree28849d9de4c54a823de3e9754292e0927274b4da
parent5efbfaf6cbb9f313cff46c4250141db36933d0c8
CustomField - simplify tableName lookup during bulkSave and fix bug

This cleans up the tableName lookup to use the method used throughout this class.
The extra optimization (local caching in the $tables variable) was actually less efficient
because CRM_Core_DAO::getFieldValue caches its results, and is used elsewhere so the value
is likely to already be cached.

The bug is that the same table name was repeatedly being passed into $logging->fixSchemaDifferencesFor().
CRM/Core/BAO/CustomField.php