php8.2 fix undeclared properties on backoffice contribution form
authorEileen McNaughton <emcnaughton@wikimedia.org>
Sat, 14 Oct 2023 05:11:53 +0000 (18:11 +1300)
committerEileen McNaughton <emcnaughton@wikimedia.org>
Sat, 14 Oct 2023 20:04:13 +0000 (09:04 +1300)
commit0246fe6b3aa744f8a40ecba98ae5c16d284cf660
tree284fb598e52466f9c7da1901e0b50d61db943148
parentb2bf0a69adef260a9aff56892a95fe44b189f17b
php8.2 fix undeclared properties on backoffice contribution form

There are just 2 properties

_payNow is distinctly internal, and easily searched in universe so I made it private

- _contributionID is specifically set for the purposes of hooks - although I expect that
was more relevant when the code was shared with the front end form. However, I have
set it up to still work for now, albeit with a deprecation notice
CRM/Contribute/Form/Contribution.php
Civi/Test/FormTrait.php
Civi/Test/FormWrapper.php
tests/phpunit/CRM/Contribute/Form/ContributionTest.php