(REF) CRM_Core_Resources - Limit visibility of `getEntityRefMetadata`
authorTim Otten <totten@civicrm.org>
Fri, 14 Jan 2022 19:54:51 +0000 (11:54 -0800)
committerTim Otten <totten@civicrm.org>
Fri, 14 Jan 2022 19:54:51 +0000 (11:54 -0800)
commit0089ae228f583816737615991ac313b5f3b8c7bd
tree4b4a81210abb7f1856b9d1077e2345c8578f3d3a
parent39d3df2e43c6e27000634fdda88385f047696a63
(REF) CRM_Core_Resources - Limit visibility of `getEntityRefMetadata`

Before
------

* `CRM_Core_Resources::getEntityRefMetadata()` is nominally `public`.
* The only callers are within `CRM_Core_Resources` and `CRM_Core_ResourcesTest`.
* It seems likely that the method was `public` to support that unit-test.
* This seems like a weird place for the method to live.

After
------

* `CRM_Core_Resources::getEntityRefMetadata()` no longer `public`.
* The method is still in a weird place, but at least no one will expect it to remain there.
CRM/Core/Resources.php
tests/phpunit/CRM/Core/ResourcesTest.php