Fix Event online receipts to display credit card info if available.
authoreileen <emcnaughton@wikimedia.org>
Fri, 18 Oct 2019 01:32:48 +0000 (14:32 +1300)
committereileen <emcnaughton@wikimedia.org>
Fri, 18 Oct 2019 01:40:55 +0000 (14:40 +1300)
commitea93110b2590c61001cf960307fd5ea1c127f051
tree615e4b152b8b1e2f200b85dc1139e38656efbfdf
parent1b6e7995573af8da98c486196b70b69426fcc85f
Fix Event online receipts to display credit card info if available.

We currently have a very complex IF clause which includes some deprecated parameters.

However, we can simplify this to simply display the information if availble. We only collect
credit card information if we require it & hence the presence of it is an adequate indicator
as to whether to display it.

We could check for credit_card_number instead but actually there is precedent in another tpl
for checking credit_card_type & it's pretty neutral as both should be present or missing
tests/phpunit/CRM/Event/Form/Registration/ConfirmTest.php
xml/templates/message_templates/event_online_receipt_html.tpl
xml/templates/message_templates/event_online_receipt_text.tpl