Fix test setup Function to use order api
authoreileen <emcnaughton@wikimedia.org>
Sat, 26 Oct 2019 23:35:28 +0000 (12:35 +1300)
committereileen <emcnaughton@wikimedia.org>
Sun, 27 Oct 2019 01:16:36 +0000 (14:16 +1300)
commitf3e6da5ee547c6a3cf4e96a972d72f1f1b7130a2
tree516eaa15b5a9fa1a150910e42dababd074efb2da
parentcb4793ed619e29fa423d4bdda0164eeb4ca23286
Fix test setup Function to use order api

After ongoing issues resolving https://github.com/civicrm/civicrm-core/pull/14763 I have concluded the underlying
issue on the failing tests is the test setup. Specifically the use of 'partial_amount_to_pay' does not
create the correct underlying entities - it 'sort of' creates a payment without linking it to
the financial items.

These parameters are part of our first attempt at partial payments. I am removing them from the test here but
will deprecate later from other places in the code
CRM/Financial/BAO/Payment.php
tests/phpunit/CiviTest/CiviUnitTestCase.php
tests/phpunit/api/v3/OrderTest.php
tests/phpunit/api/v3/PaymentTest.php