dev/core#389 [preliminary cleanup] Standardise metadat for custom field use
authoreileen <emcnaughton@wikimedia.org>
Thu, 30 May 2019 22:45:06 +0000 (10:45 +1200)
committereileen <emcnaughton@wikimedia.org>
Sun, 2 Jun 2019 01:48:03 +0000 (13:48 +1200)
commit8392a043991f0682272f8363b15c53b273c9eb06
treea30fc1197f0068da9bc2ccd48d79c631b65043ad
parent7f45679a57cfe6627879aedb89acac9a383b4925
dev/core#389 [preliminary cleanup] Standardise metadat for custom field use

In digging into dev/core#389 I found a major complexity in fixing it was inconsistent metadata available at different
points in the code. This simply adds metadata to the 'inner-most place' & makes the BAO_CustomQuery object use that

I didn't remove the options loop because I wanted to leave that out of scope as I can't see how / if it is used

[test] add test for getImportableFields
tests/phpunit/CRM/Core/BAO/CustomFieldTest.php
tests/phpunit/CRMTraits/Custom/CustomDataTrait.php