dev/core#755 - CRM/Core - Fix missing group name in custom field cache
authorPatrick Figel <pfigel@greenpeace.org>
Wed, 27 Mar 2019 20:46:50 +0000 (21:46 +0100)
committerPatrick Figel <patrick@figel.email>
Wed, 27 Mar 2019 20:46:50 +0000 (21:46 +0100)
commit30b6e00250ca2f39e6647a938018b3607bc619a5
treeabe03a70a962c4804b296a9c349bdb07b4f288c3
parent8f61a3e91bf5fe2292cf3f5fbd1e5662364bd02f
dev/core#755 - CRM/Core - Fix missing group name in custom field cache

CRM_Core_BAO_CustomField::getCustomFieldID caches custom fields based
on the field name, meaning if a custom field of the same name exists
in more than one group, the method will always return the first field
that was cached. This change adds the $groupName parameter to the
cache key.

This also adds a missing test for the $fullString parameter and
renames the $groupTitle parameter to $groupName in preparation
for future changes.
CRM/Core/BAO/CustomField.php
tests/phpunit/CRM/Core/BAO/CustomFieldTest.php