CRM-17335 reduce use of nullArray
authoreileen <emcnaughton@wikimedia.org>
Tue, 10 May 2016 23:16:32 +0000 (11:16 +1200)
committereileen <emcnaughton@wikimedia.org>
Tue, 10 May 2016 23:17:10 +0000 (11:17 +1200)
commit33621c4fe0987a20f438a92fbea864d985dab1f9
tree2978936c71d7b55a5dcfaef79c14b06c9c8cd995
parent46dc2dddbae1c0c3b53807e76bff159009d992e3
CRM-17335 reduce use of nullArray

The null array static is a work-around for pass-by-reference signatures but the executeQuery no longer requires it.

It's not actually 'just' tidy-up as the array can become contaminated, leading to hard to diagnose bugs.

Note there is one instance of a similar tidy up on contribution::create in this - the  parameter is no longer mandatory & we call this function so often I feel confident about removing the stray & too
38 files changed:
CRM/ACL/Page/ACL.php
CRM/ACL/Page/ACLBasic.php
CRM/Activity/Form/Task/SearchTaskHookSample.php
CRM/Admin/Form/LocationType.php
CRM/Admin/Form/PaymentProcessor.php
CRM/Admin/Form/PaymentProcessorType.php
CRM/Badge/BAO/Layout.php
CRM/Campaign/BAO/Survey.php
CRM/Case/BAO/Case.php
CRM/Case/Form/Task/SearchTaskHookSample.php
CRM/Contact/BAO/Contact.php
CRM/Contact/BAO/Contact/Utils.php
CRM/Contact/BAO/Relationship.php
CRM/Contact/Form/Task/PDFLetterCommon.php
CRM/Contribute/BAO/Contribution.php
CRM/Contribute/BAO/ContributionRecur.php
CRM/Core/BAO/LabelFormat.php
CRM/Core/BAO/LocationType.php
CRM/Core/BAO/PaperSize.php
CRM/Core/BAO/PdfFormat.php
CRM/Core/BAO/Tag.php
CRM/Custom/Form/Field.php
CRM/Event/BAO/Event.php
CRM/Event/BAO/Participant.php
CRM/Event/Form/SelfSvcTransfer.php
CRM/Event/Form/SelfSvcUpdate.php
CRM/Event/Form/Task/SearchTaskHookSample.php
CRM/Grant/BAO/Grant.php
CRM/Grant/Form/Task/SearchTaskHookSample.php
CRM/Mailing/Event/BAO/Queue.php
CRM/Mailing/Event/BAO/Unsubscribe.php
CRM/Mailing/Form/Subscribe.php
CRM/Member/BAO/MembershipStatus.php
CRM/Report/Form.php
bin/ContributionProcessor.php
sql/GenerateGroups.php
sql/GenerateMailing.php
sql/GenerateReportData.php