Simplify caching of status checks and fixes missing domain_id condition
authorColeman Watts <coleman@civicrm.org>
Mon, 13 Jul 2020 18:26:46 +0000 (14:26 -0400)
committerColeman Watts <coleman@civicrm.org>
Wed, 22 Jul 2020 19:08:46 +0000 (15:08 -0400)
commit1416a3c475b44331dfac952afc2be76476d91da3
tree5d1e2221eac1d36f209b69e1b7fc3099285d188f
parent21b7b302ced3053b27da2c743a434ab3f73758ea
Simplify caching of status checks and fixes missing domain_id condition

Fixes a few apparent problems:
- domain_id was ommitted causing unexpected results
- Civi::cache was being read but never written to
- Object caching did not persist in memory across different check classes
- If we did write to Civi::cache there is no mechanism for clearing that cache when data changes

Solution: use simple array cache in Civi::$statics
CRM/Utils/Check/Component.php