Cleanup core pseudoconstant buildOptions
authorColeman Watts <coleman@civicrm.org>
Tue, 21 Apr 2020 01:36:13 +0000 (21:36 -0400)
committerColeman Watts <coleman@civicrm.org>
Thu, 23 Apr 2020 23:58:50 +0000 (19:58 -0400)
commit398683876c9abe34b8a7b7016b057af4ca9068e9
treeb6b3ebf5517447dda4b58c04d527945b97dc8553
parent35f615567f118ed63ea24dec70dba3fc093dab9c
Cleanup core pseudoconstant buildOptions

There has been some confusion about the $params vs $props variables, and some code was mistakenly using them interchangeably.
They are not the same, as CRM_Core_PseudoConstant::get expects sanitized input for $params, but CRM_*_DAO::buildOptions accepts raw user input as $props.
CRM/ACL/BAO/ACL.php
CRM/Contact/BAO/GroupContact.php
CRM/Contribute/BAO/ContributionRecur.php
CRM/Core/DAO.php
CRM/Price/Form/Field.php
CRM/Price/Form/Option.php
tests/phpunit/CRM/Price/Form/FieldTest.php
tests/phpunit/CRM/Price/Form/OptionTest.php
tests/phpunit/api/v3/ReportTemplateTest.php