Remove inheritance of MembershipConfig form from MembershipStatus form.
authoreileen <emcnaughton@wikimedia.org>
Wed, 23 May 2018 03:23:40 +0000 (15:23 +1200)
committereileen <emcnaughton@wikimedia.org>
Sun, 27 May 2018 21:47:31 +0000 (09:47 +1200)
commit3a0ba1c541d1c53d6bbdcf9ae7d6508346df0262
tree93042eb58e8561f28808010ae5ce9ab07bdfb5d9
parent0763d2bdf1439b5e3bcf296bb4dafb1004d27e13
Remove inheritance of MembershipConfig form from MembershipStatus form.

This is part of trying to move towards an entity form (ie. support custom data) for MembershipType.

Currently the 2 forms share a parent class - but really the add buttons is the only shared functionality.

This change uses the EntityTrait to add the buttons as well. There is some minor tidy up in there
but I tried to keep it very limited.

I switched only one field over to being added via addField, the parent mechanism so far
CRM/Core/Form/EntityFormTrait.php
CRM/Member/DAO/MembershipStatus.php
CRM/Member/Form/MembershipConfig.php
CRM/Member/Form/MembershipStatus.php
templates/CRM/Member/Form/MembershipStatus.tpl
xml/schema/Member/MembershipStatus.xml