Fix theoretical regression
authoreileen <emcnaughton@wikimedia.org>
Mon, 17 Feb 2020 08:04:00 +0000 (21:04 +1300)
committereileen <emcnaughton@wikimedia.org>
Mon, 17 Feb 2020 08:04:58 +0000 (21:04 +1300)
commitfc076fe3fbe3fd15336c3cf32427f8d88c858f95
tree082666877773e4d58c135fc3956ff3af997dbf86
parent075e18d327223282b0a37f6309dd5802700b6715
Fix theoretical regression

This PR https://github.com/civicrm/civicrm-core/pull/16363/commits/44237a295dc5eab4f6110fb0556b1af742364f6e
(merged to 5.23) calls self::::getDefaultRoleID() in a way that was always flawed but definitely woudl
not work now. I think it is never reached but better to put this fix into 5.23 & maybe reemove the line in master
later since it assumes participant_status_id is optional - which is not true of the backoffice form
CRM/Event/BAO/Participant.php
CRM/Event/Form/Participant.php
CRM/Event/Form/Registration.php