[REF] remove call to deprecated function
authoreileen <emcnaughton@wikimedia.org>
Wed, 9 Oct 2019 11:26:09 +0000 (13:26 +0200)
committereileen <emcnaughton@wikimedia.org>
Wed, 9 Oct 2019 11:31:01 +0000 (13:31 +0200)
commita168b222cb4f6f562af143d60d0d0de525dcc7d9
tree1c6bde595980318d8d0c1bd9f35946c2c5cc9090
parent59be822a4dbb8605c07078dc9508b4a1afbbdb3b
[REF] remove call to deprecated function

getPartialPaymentType basically just calls CRM_Contribute_BAO_Contribution::getContributionBalance
& then returns the  balance in a different array key depending on the value.

This switches to calling it directly & completes the work of removing all calls to it & more heavily deprecating it
CRM/Contribute/Form/AdditionalPayment.php
CRM/Core/BAO/FinancialTrxn.php
tests/phpunit/CRM/Core/BAO/FinancialTrxnTest.php