projects / civicrm-core.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ee3bab5) | patch
Remove unnecessary, and possibly incorrect query from email update
authoreileen <emcnaughton@wikimedia.org>
Tue, 10 Dec 2019 23:42:47 +0000 (12:42 +1300)
committereileen <emcnaughton@wikimedia.org>
Wed, 11 Dec 2019 11:02:18 +0000 (00:02 +1300)
commit2ffdaed1d83574812251e3b8a5c23672b7b2b38d
tree14580f5de4b55f5c3f153b8316d51339ed2f78d6tree | snapshot (zip tar.gz)
parentee3bab5603fcac14174948ed640fa92be8798c83commit | diff
Remove unnecessary, and possibly incorrect query from email update

When updating an email the comments pretty clearly say to update bulkmail if it is 1 but the current if clause
picks up anything other than 'null' - which is invalid for a boolean field. This creates an additional query which has some
locking risk being in a high volume place. In addition it seems like it could be a bug in some cases
CRM/Core/BAO/Email.php diff | blob | blame | history
tests/phpunit/CRM/Core/BAO/EmailTest.php diff | blob | blame | history
tests/phpunit/api/v3/EmailTest.php diff | blob | blame | history