ensure recur options are present on backend cc contribution form.
authorJamie McClelland <jm@mayfirst.org>
Wed, 22 Sep 2021 14:00:36 +0000 (10:00 -0400)
committerJamie McClelland <jm@mayfirst.org>
Thu, 23 Sep 2021 15:43:44 +0000 (11:43 -0400)
commit3148d4cdfd4872168147f68852ae642c0c8ab67b
tree5ae5cb09810875759fb67955de206e00a878438c
parent07f3305395d6c5ba1830e9558cd547fd43c6fe20
ensure recur options are present on backend cc contribution form.

We seem to be adding an extra check to see if the given
payment processor has any credit card fields before including the
recur option on the backend contribution page. But some processors,
like Stripe, insert the fields via javascript. It should be enough
to just test for the existence of a payment processor that supports
recur to run the block.

Also, no other code is checking the return value of buildPaymentForm
so removing it.
CRM/Contribute/Form/Contribution.php
CRM/Core/Payment/Form.php