dev/core#1409 Remove net_amount from Addtional Payment form
authoreileen <emcnaughton@wikimedia.org>
Wed, 20 Nov 2019 04:54:22 +0000 (17:54 +1300)
committereileen <emcnaughton@wikimedia.org>
Wed, 20 Nov 2019 18:50:17 +0000 (07:50 +1300)
commitf52694340988cd29f5f80b6392e7662bf33e8bf2
tree3d23dd4c645e814ae972c0c3cb5012d854c00d2c
parente5ebe87ddfd080ff6dd1ccfc7f26bdaeddc3b2b7
dev/core#1409 Remove net_amount from Addtional Payment form

This is causing a validation problem. We used to have an issue on the contribution form which we eventually
resolved by removing net_amount as it's best calculated anyway

In order to make this changed I had to ensure Payment.create adds the net_amount & had
to do a couple of tweaks for the test to pass
CRM/Contribute/Form/AdditionalPayment.php
CRM/Core/BAO/FinancialTrxn.php
api/v3/Payment.php
templates/CRM/Contribute/Form/AdditionalPayment.tpl
tests/phpunit/api/v3/PaymentTest.php
tests/phpunit/api/v3/SyntaxConformanceTest.php