(dev/core#217) PrevNext - Remove references to entity_table and entity_id2 from service
authorTim Otten <totten@civicrm.org>
Sun, 8 Jul 2018 02:31:36 +0000 (19:31 -0700)
committerTim Otten <totten@civicrm.org>
Thu, 16 Aug 2018 23:28:23 +0000 (16:28 -0700)
commitec19219788e978e0e3f15a71031ffc3d3585c0c3
treeedb1d4c0d7228cd6c4aab2c1630adfae60f27ac8
parent230a99386efa115bd8aef24b2043399b644fbb27
(dev/core#217) PrevNext - Remove references to entity_table and entity_id2 from service

The PrevNext service/interface aims to be a replaceable component for use
the search-caching (but not deduping).

The interface that we produced from refactoring includes several references
to `entity_table` and `entity_id2` -- these values are part of the SQL
table, and they're needed for dedupe, but they don't seem to convey anything
meaningful for search-caching.  Including these fields makes the interface
more complicated -- which will make it hard to implement other variants.

The general gist of this commit is that we no longer fill those two columns,
and we no longer read them.

In a couple functions, we split the new OOP implementation
(`CRM_Core_PrevNextCache_Sql`) from the traditional static BAO
implementation (`CRM_Core_BAO_PrevNext`) so that we can omit these fields.
CRM/Campaign/Selector/Search.php
CRM/Contact/Selector.php
CRM/Core/PrevNextCache/Interface.php
CRM/Core/PrevNextCache/Sql.php