CRM-20199 Remove poor join on option_value table when doing contribution search.
authoreileen <emcnaughton@wikimedia.org>
Thu, 2 Mar 2017 23:05:54 +0000 (12:05 +1300)
committereileen <emcnaughton@wikimedia.org>
Fri, 3 Mar 2017 05:29:12 +0000 (18:29 +1300)
commit9d5c7f144af35638671f6c79c86b6dd1b6111f99
tree0a501fb61a14fdd77dcf1ee6345b4d86bdb84146
parenta1fdbc22b4893e13add884b211c98a4b16880007
CRM-20199 Remove poor join on option_value table when doing contribution search.

This involves setting payment instrument to exportable & remove hacks that were used in
place of doing that, and adding new logic to the order by to allow it to order without
joining the option value table (using the field() function).

I have observed one small regression which is the Qill showing 'Payment Method ID'
instead of payment method. I'm committed to fixing that but I would push
to merge this in advance of that because we are in the best place in the monthly
cycle to merge this and that is a very minor fallout.
14 files changed:
CRM/Contact/BAO/Query.php
CRM/Contact/Selector.php
CRM/Contribute/BAO/Contribution.php
CRM/Contribute/BAO/Query.php
CRM/Contribute/DAO/Contribution.php
CRM/Contribute/Selector/Search.php
CRM/Core/BAO/Mapping.php
CRM/Core/BAO/OptionGroup.php
CRM/Core/DAO.php
CRM/Core/DAO/AllCoreTables.data.php
CRM/Utils/Rule.php
CRM/Utils/Type.php
tests/phpunit/CRM/Utils/TypeTest.php
xml/schema/Contribute/Contribution.xml