Distinguish custom field VIEW from EDIT permissions
authorColeman Watts <coleman@civicrm.org>
Mon, 12 Jul 2021 23:45:35 +0000 (19:45 -0400)
committerColeman Watts <coleman@civicrm.org>
Tue, 20 Jul 2021 17:49:29 +0000 (13:49 -0400)
commit317103abfb7f5ed64c27aa2350cd115027638359
tree4403de31b1c68e8f7387473fc8b7c7b857f6dbc0
parent3a6233a1374e46d1b977c3e134803bfe442d0b40
Distinguish custom field VIEW from EDIT permissions

Before: CustomGroup ACLs made no distinction between VIEW and EDIT

After: User with VIEW can see a custom group but not edit it, both in the UI and the API.
41 files changed:
CRM/Activity/Form/Activity.php
CRM/Case/Form/CaseView.php
CRM/Contact/BAO/Contact.php
CRM/Contact/BAO/Relationship.php
CRM/Contact/Form/CustomData.php
CRM/Contact/Form/Search/Custom/ActivitySearch.php
CRM/Contact/Form/Search/Custom/MultipleValues.php
CRM/Contact/Page/AJAX.php
CRM/Contact/Page/Inline/CustomData.php
CRM/Contact/Page/View/CustomData.php
CRM/Contact/Page/View/Relationship.php
CRM/Contact/Page/View/Summary.php
CRM/Contribute/Form/ContributionView.php
CRM/Contribute/Page/ContributionRecur.php
CRM/Core/BAO/Address.php
CRM/Core/BAO/CustomField.php
CRM/Core/BAO/CustomGroup.php
CRM/Core/BAO/CustomValue.php
CRM/Core/BAO/UFGroup.php
CRM/Core/Permission.php
CRM/Custom/Form/CustomData.php
CRM/Custom/Page/AJAX.php
CRM/Dedupe/Merger.php
CRM/Event/Form/ParticipantView.php
CRM/Event/Page/EventInfo.php
CRM/Grant/Form/GrantView.php
CRM/Member/Form/MembershipView.php
CRM/Pledge/Form/PledgeView.php
CRM/Profile/Page/MultipleRecordFieldsListing.php
Civi/Api4/CustomValue.php
Civi/Api4/Generic/Traits/CustomValueActionTrait.php
Civi/Api4/Generic/Traits/DAOActionTrait.php
Civi/Api4/Service/Schema/Joiner.php
api/v3/CustomValue.php
api/v3/utils.php
templates/CRM/ACL/Form/ACL.tpl
templates/CRM/Contact/Page/View/CustomDataFieldView.tpl
templates/CRM/Custom/Page/CustomDataView.tpl
templates/CRM/Profile/Page/MultipleRecordFieldsListing.tpl
tests/phpunit/api/v3/ACLPermissionTest.php
tests/phpunit/api/v4/Action/CustomGroupACLTest.php [new file with mode: 0644]