Reduce calls to CRM_Member_PseudoConstant::membershipType
authoreileen <emcnaughton@wikimedia.org>
Wed, 29 Jul 2020 00:14:30 +0000 (12:14 +1200)
committereileen <emcnaughton@wikimedia.org>
Wed, 29 Jul 2020 01:24:32 +0000 (13:24 +1200)
commita89e0a3e110e8ff459a9737c2022395645906459
tree385172d863a2d4c566539a84d6f8dad4aa9e47f3
parentaa328fcee07bfe3823cc190c8b011ac5ad130fce
Reduce calls to CRM_Member_PseudoConstant::membershipType

This function defaults to not using the cached version so that's a pretty good argument for making a more
active effort to deprecate it. The createMembership function flushes it so we don't need to do that
so much in tests now either. I also included swapping status over in the test
CRM/Activity/BAO/Activity.php
CRM/Member/BAO/Membership.php
tests/phpunit/CRM/Core/Payment/BaseIPNTest.php
tests/phpunit/api/v3/MembershipTest.php