X-Git-Url: https://vcs.fsf.org/?a=blobdiff_plain;f=tests%2Fphpunit%2Fapi%2Fv4%2FAction%2FFkJoinTest.php;h=602942f93dc4762dab2f33ea123717f60e1834ea;hb=952e2a50682ed31cb50211da70d74ffcd9c301c2;hp=babd1cec0fabeb1dda14764ab839aef72eefa605;hpb=76edc0b3e4c05c2db1f6fed6f2168d9dba6f98d1;p=civicrm-core.git

diff --git a/tests/phpunit/api/v4/Action/FkJoinTest.php b/tests/phpunit/api/v4/Action/FkJoinTest.php
index babd1cec0f..602942f93d 100644
--- a/tests/phpunit/api/v4/Action/FkJoinTest.php
+++ b/tests/phpunit/api/v4/Action/FkJoinTest.php
@@ -24,6 +24,8 @@ namespace api\v4\Action;
 use api\v4\UnitTestCase;
 use Civi\Api4\Activity;
 use Civi\Api4\Contact;
+use Civi\Api4\Email;
+use Civi\Api4\Phone;
 
 /**
  * @group headless
@@ -55,40 +57,87 @@ class FkJoinTest extends UnitTestCase {
     $this->assertCount(1, $results);
   }
 
-  public function testActivityContactJoin() {
-    $results = Activity::get()
+  public function testOptionalJoin() {
+    // DefaultDataSet includes 2 phones for contact 1, 0 for contact 2.
+    // We'll add one for contact 2 as a red herring to make sure we only get back the correct ones.
+    Phone::create()->setCheckPermissions(FALSE)
+      ->setValues(['contact_id' => $this->getReference('test_contact_2')['id'], 'phone' => '123456'])
+      ->execute();
+    $contacts = Contact::get()
       ->setCheckPermissions(FALSE)
-      ->addSelect('assignees.id')
-      ->addSelect('assignees.first_name')
-      ->addSelect('assignees.display_name')
-      ->addWhere('assignees.first_name', '=', 'Phoney')
+      ->addJoin('Phone', FALSE)
+      ->addSelect('id', 'phone.phone')
+      ->addWhere('id', 'IN', [$this->getReference('test_contact_1')['id']])
+      ->addOrderBy('phone.id')
       ->execute();
+    $this->assertCount(2, $contacts);
+    $this->assertEquals($this->getReference('test_contact_1')['id'], $contacts[0]['id']);
+    $this->assertEquals($this->getReference('test_contact_1')['id'], $contacts[1]['id']);
+  }
 
-    $firstResult = $results->first();
-
-    $this->assertCount(1, $results);
-    $this->assertTrue(is_array($firstResult['assignees']));
+  public function testRequiredJoin() {
+    // Joining with no condition
+    $contacts = Contact::get()
+      ->setCheckPermissions(FALSE)
+      ->addSelect('id', 'phone.phone')
+      ->addJoin('Phone', TRUE)
+      ->addWhere('id', 'IN', [$this->getReference('test_contact_1')['id'], $this->getReference('test_contact_2')['id']])
+      ->addOrderBy('phone.id')
+      ->execute();
+    $this->assertCount(2, $contacts);
+    $this->assertEquals($this->getReference('test_contact_1')['id'], $contacts[0]['id']);
+    $this->assertEquals($this->getReference('test_contact_1')['id'], $contacts[1]['id']);
 
-    $firstAssignee = array_shift($firstResult['assignees']);
-    $this->assertEquals($firstAssignee['first_name'], 'Phoney');
+    // Add is_primary condition, should result in only one record
+    $contacts = Contact::get()
+      ->setCheckPermissions(FALSE)
+      ->addSelect('id', 'phone.phone', 'phone.location_type_id')
+      ->addJoin('Phone', TRUE, ['phone.is_primary', '=', TRUE])
+      ->addWhere('id', 'IN', [$this->getReference('test_contact_1')['id'], $this->getReference('test_contact_2')['id']])
+      ->addOrderBy('phone.id')
+      ->execute();
+    $this->assertCount(1, $contacts);
+    $this->assertEquals($this->getReference('test_contact_1')['id'], $contacts[0]['id']);
+    $this->assertEquals('+35355439483', $contacts[0]['phone.phone']);
+    $this->assertEquals('1', $contacts[0]['phone.location_type_id']);
   }
 
-  public function testContactPhonesJoin() {
-    $testContact = $this->getReference('test_contact_1');
-    $testPhone = $this->getReference('test_phone_1');
+  public function testJoinToTheSameTableTwice() {
+    $cid1 = Contact::create()->setCheckPermissions(FALSE)
+      ->addValue('first_name', 'Aaa')
+      ->addChain('email1', Email::create()->setValues(['email' => 'yoohoo@yahoo.test', 'contact_id' => '$id', 'location_type_id:name' => 'Home']))
+      ->addChain('email2', Email::create()->setValues(['email' => 'yahoo@yoohoo.test', 'contact_id' => '$id', 'location_type_id:name' => 'Work']))
+      ->execute()
+      ->first()['id'];
 
-    $results = Contact::get()
-      ->setCheckPermissions(FALSE)
-      ->addSelect('phones.phone')
-      ->addWhere('id', '=', $testContact['id'])
-      ->addWhere('phones.location_type.name', '=', 'Home')
+    $cid2 = Contact::create()->setCheckPermissions(FALSE)
+      ->addValue('first_name', 'Bbb')
+      ->addChain('email1', Email::create()->setValues(['email' => '1@test.test', 'contact_id' => '$id', 'location_type_id:name' => 'Home']))
+      ->addChain('email2', Email::create()->setValues(['email' => '2@test.test', 'contact_id' => '$id', 'location_type_id:name' => 'Work']))
+      ->addChain('email3', Email::create()->setValues(['email' => '3@test.test', 'contact_id' => '$id', 'location_type_id:name' => 'Other']))
       ->execute()
-      ->first();
+      ->first()['id'];
 
-    $this->assertArrayHasKey('phones', $results);
-    $this->assertCount(1, $results['phones']);
-    $firstPhone = array_shift($results['phones']);
-    $this->assertEquals($testPhone['phone'], $firstPhone['phone']);
+    $cid3 = Contact::create()->setCheckPermissions(FALSE)
+      ->addValue('first_name', 'Ccc')
+      ->execute()
+      ->first()['id'];
+
+    $contacts = Contact::get()
+      ->setCheckPermissions(FALSE)
+      ->addSelect('id', 'first_name', 'any_email.email', 'any_email.location_type_id:name', 'any_email.is_primary', 'primary_email.email')
+      ->addJoin('Email AS any_email', TRUE)
+      ->addJoin('Email AS primary_email', FALSE, ['primary_email.is_primary', '=', TRUE])
+      ->addWhere('id', 'IN', [$cid1, $cid2, $cid3])
+      ->addOrderBy('any_email.id')
+      ->setDebug(TRUE)
+      ->execute();
+    $this->assertCount(5, $contacts);
+    $this->assertEquals('Home', $contacts[0]['any_email.location_type_id:name']);
+    $this->assertEquals('yoohoo@yahoo.test', $contacts[1]['primary_email.email']);
+    $this->assertEquals('1@test.test', $contacts[2]['primary_email.email']);
+    $this->assertEquals('1@test.test', $contacts[3]['primary_email.email']);
+    $this->assertEquals('1@test.test', $contacts[4]['primary_email.email']);
   }
 
 }