X-Git-Url: https://vcs.fsf.org/?a=blobdiff_plain;f=tests%2Fphpunit%2Fapi%2Fv3%2FActionScheduleTest.php;h=0c7da114d6c266cd8b0d5c71364f8f2264978d21;hb=50a2375554b2a33cacebbe3822ff3c84f60fb9e9;hp=e403dd2debc05f7ebbea6c02bca41223d86df2b4;hpb=f0be539ab293fe193f7160994a4e4c7b25334f5e;p=civicrm-core.git

diff --git a/tests/phpunit/api/v3/ActionScheduleTest.php b/tests/phpunit/api/v3/ActionScheduleTest.php
index e403dd2deb..0c7da114d6 100644
--- a/tests/phpunit/api/v3/ActionScheduleTest.php
+++ b/tests/phpunit/api/v3/ActionScheduleTest.php
@@ -1,6 +1,7 @@
 <?php
 /**
- *  File for the TestActionSchedule class
+ * @file
+ * File for the TestActionSchedule class
  *
  *  (PHP 5)
  *
@@ -37,26 +38,25 @@ class api_v3_ActionScheduleTest extends CiviUnitTestCase {
   protected $_entity = 'action_schedule';
   protected $_apiversion = 3;
 
-
   /**
-   *  Test setup for every test
-   *
-   *  Connect to the database, truncate the tables that will be used
-   *  and redirect stdin to a temporary file
+   * Test setup for every test.
    */
   public function setUp() {
-    //  Connect to the database
     parent::setUp();
     $this->useTransaction(TRUE);
   }
 
+  /**
+   * Test simple create action schedule.
+   */
   public function testSimpleActionScheduleCreate() {
     $oldCount = CRM_Core_DAO::singleValueQuery('select count(*) from civicrm_action_schedule');
     $activityContacts = CRM_Core_OptionGroup::values('activity_contacts', FALSE, FALSE, FALSE, NULL, 'name');
     $assigneeID = CRM_Utils_Array::key('Activity Assignees', $activityContacts);
-    $targetID = CRM_Utils_Array::key('Activity Targets', $activityContacts);
     $scheduledStatus = CRM_Core_OptionGroup::getValue('activity_status', 'Scheduled', 'name');
-    $mappingId = CRM_Core_DAO::getFieldValue('CRM_Core_DAO_ActionMapping', 'activity_type', 'id', 'entity_value');
+    $mapping = CRM_Utils_Array::first(CRM_Core_BAO_ActionSchedule::getMappings(array(
+      'entity_value' => 'activity_type',
+    )));
     $activityTypeId = CRM_Core_OptionGroup::getValue('activity_type', "Meeting", 'name');
     $title = "simpleActionSchedule" . substr(sha1(rand()), 0, 7);
     $params = array(
@@ -68,17 +68,17 @@ class api_v3_ActionScheduleTest extends CiviUnitTestCase {
       'is_active' => 1,
       'record_activity' => 1,
       'start_action_date' => 'activity_date_time',
-      'mapping_id' => $mappingId,
+      'mapping_id' => $mapping->id,
     );
     $actionSchedule = $this->callAPISuccess('action_schedule', 'create', $params);
-    $this->assertTrue(is_numeric($actionSchedule['id']), "In line " . __LINE__);
-    $this->assertTrue($actionSchedule['id'] > 0, "In line " . __LINE__);
+    $this->assertTrue(is_numeric($actionSchedule['id']));
+    $this->assertTrue($actionSchedule['id'] > 0);
     $newCount = CRM_Core_DAO::singleValueQuery('select count(*) from civicrm_action_schedule');
     $this->assertEquals($oldCount + 1, $newCount);
   }
 
   /**
-   * Check if required fields are not passed
+   * Check if required fields are not passed.
    */
   public function testActionScheduleCreateWithoutRequired() {
     $params = array(
@@ -89,14 +89,16 @@ class api_v3_ActionScheduleTest extends CiviUnitTestCase {
   }
 
   /**
-   *
+   * Test create with scheduled dates.
    */
   public function testActionScheduleWithScheduledDatesCreate() {
     $oldCount = CRM_Core_DAO::singleValueQuery('select count(*) from civicrm_action_schedule');
     $activityContacts = CRM_Core_OptionGroup::values('activity_contacts', FALSE, FALSE, FALSE, NULL, 'name');
     $assigneeID = CRM_Utils_Array::key('Activity Assignees', $activityContacts);
     $scheduledStatus = CRM_Core_OptionGroup::getValue('activity_status', 'Scheduled', 'name');
-    $mappingId = CRM_Core_DAO::getFieldValue('CRM_Core_DAO_ActionMapping', 'activity_type', 'id', 'entity_value');
+    $mapping = CRM_Utils_Array::first(CRM_Core_BAO_ActionSchedule::getMappings(array(
+      'entity_value' => 'activity_type',
+    )));
     $activityTypeId = CRM_Core_OptionGroup::getValue('activity_type', "Meeting", 'name');
     $title = "simpleActionSchedule" . substr(sha1(rand()), 0, 7);
     $params = array(
@@ -107,7 +109,7 @@ class api_v3_ActionScheduleTest extends CiviUnitTestCase {
       'entity_status' => $scheduledStatus,
       'is_active' => 1,
       'record_activity' => 1,
-      'mapping_id' => $mappingId,
+      'mapping_id' => $mapping->id,
       'start_action_offset' => 3,
       'start_action_unit' => 'day',
       'start_action_condition' => 'before',
@@ -123,8 +125,8 @@ class api_v3_ActionScheduleTest extends CiviUnitTestCase {
       'subject' => 'Test subject',
     );
     $actionSchedule = $this->callAPISuccess('action_schedule', 'create', $params);
-    $this->assertTrue(is_numeric($actionSchedule['id']), "In line " . __LINE__);
-    $this->assertTrue($actionSchedule['id'] > 0, "In line " . __LINE__);
+    $this->assertTrue(is_numeric($actionSchedule['id']));
+    $this->assertTrue($actionSchedule['id'] > 0);
     $this->assertEquals($actionSchedule['values'][$actionSchedule['id']]['start_action_offset'][0], $params['start_action_offset']);
     $newCount = CRM_Core_DAO::singleValueQuery('select count(*) from civicrm_action_schedule');
     $this->assertEquals($oldCount + 1, $newCount);