X-Git-Url: https://vcs.fsf.org/?a=blobdiff_plain;f=tests%2Fphpunit%2FCRM%2FCore%2FBAO%2FNavigationTest.php;h=5b16491b1712800949d05934e5e04635f27ec633;hb=64c50b693785c6c7ed9a9a7fe8f360e8dc667ab0;hp=fab453d83e677ca107d3fe8769c46af63607e362;hpb=f6af7e6f06447f2725f5878bb824b8e792d3cc30;p=civicrm-core.git

diff --git a/tests/phpunit/CRM/Core/BAO/NavigationTest.php b/tests/phpunit/CRM/Core/BAO/NavigationTest.php
index fab453d83e..5b16491b17 100644
--- a/tests/phpunit/CRM/Core/BAO/NavigationTest.php
+++ b/tests/phpunit/CRM/Core/BAO/NavigationTest.php
@@ -57,10 +57,10 @@ class CRM_Core_BAO_NavigationTest extends CiviUnitTestCase {
    * by rebuilding reports.
    */
   public function testNoDuplicateAllReportsLink() {
-    $existing_links = $this->callAPISuccess('Navigation', 'get', array('label' => 'All Reports', 'sequential' => 1));
+    $existing_links = $this->callAPISuccess('Navigation', 'get', ['label' => 'All Reports', 'sequential' => 1]);
     $this->assertNotEquals($existing_links['values'][0]['parent_id'], $existing_links['values'][1]['parent_id']);
     CRM_Core_BAO_Navigation::rebuildReportsNavigation(CRM_Core_Config::domainID());
-    $new_links = $this->callAPISuccess('Navigation', 'get', array('label' => 'All Reports', 'sequential' => 1));
+    $new_links = $this->callAPISuccess('Navigation', 'get', ['label' => 'All Reports', 'sequential' => 1]);
     $this->assertEquals($existing_links['values'][0]['parent_id'], $new_links['values'][0]['parent_id']);
     $this->assertEquals($existing_links['values'][1]['parent_id'], $new_links['values'][1]['parent_id']);
   }
@@ -98,16 +98,16 @@ class CRM_Core_BAO_NavigationTest extends CiviUnitTestCase {
     $name = "Test Menu Link {$random_string}";
     $url = "civicrm/test/{$random_string}";
     $url_params = "reset=1";
-    $params = array(
+    $params = [
       'name' => $name,
       'label' => ts($name),
       'url' => "{$url}?{$url_params}",
       'parent_id' => NULL,
       'is_active' => TRUE,
-      'permission' => array(
+      'permission' => [
         'access CiviCRM',
-      ),
-    );
+      ],
+    ];
     CRM_Core_BAO_Navigation::add($params);
     $new_nav = CRM_Core_BAO_Navigation::getNavItemByUrl($url, $url_params);
     $this->assertObjectHasAttribute('id', $new_nav);
@@ -126,16 +126,16 @@ class CRM_Core_BAO_NavigationTest extends CiviUnitTestCase {
     $name = "Test Menu Link {$random_string}";
     $url = "civicrm/test/{$random_string}";
     $url_params = "reset=1&output=criteria";
-    $params = array(
+    $params = [
       'name' => $name,
       'label' => ts($name),
       'url' => "{$url}?{$url_params}",
       'parent_id' => NULL,
       'is_active' => TRUE,
-      'permission' => array(
+      'permission' => [
         'access CiviCRM',
-      ),
-    );
+      ],
+    ];
     CRM_Core_BAO_Navigation::add($params);
     $new_nav = CRM_Core_BAO_Navigation::getNavItemByUrl($url, 'reset=1%');
     $this->assertObjectHasAttribute('id', $new_nav);
@@ -169,24 +169,24 @@ class CRM_Core_BAO_NavigationTest extends CiviUnitTestCase {
    * everywhere. They should be unchanged.
    */
   public function testFixNavigationMenu_preserveIDs() {
-    $input[10] = array(
-      'attributes' => array(
+    $input[10] = [
+      'attributes' => [
         'label' => 'Custom Menu Entry',
         'parentID' => NULL,
         'navID' => 10,
         'active' => 1,
-      ),
-      'child' => array(
-        '11' => array(
-          'attributes' => array(
+      ],
+      'child' => [
+        '11' => [
+          'attributes' => [
             'label' => 'Custom Child Menu',
             'parentID' => 10,
             'navID' => 11,
-          ),
+          ],
           'child' => NULL,
-        ),
-      ),
-    );
+        ],
+      ],
+    ];
 
     $output = $input;
     CRM_Core_BAO_Navigation::fixNavigationMenu($output);
@@ -202,29 +202,29 @@ class CRM_Core_BAO_NavigationTest extends CiviUnitTestCase {
    * should be filled in, and others should be preserved.
    */
   public function testFixNavigationMenu_inferIDs() {
-    $input[10] = array(
-      'attributes' => array(
+    $input[10] = [
+      'attributes' => [
         'label' => 'Custom Menu Entry',
         'parentID' => NULL,
         'navID' => 10,
         'active' => 1,
-      ),
-      'child' => array(
-        '0' => array(
-          'attributes' => array(
+      ],
+      'child' => [
+        '0' => [
+          'attributes' => [
             'label' => 'Custom Child Menu',
-          ),
+          ],
           'child' => NULL,
-        ),
-        '100' => array(
-          'attributes' => array(
+        ],
+        '100' => [
+          'attributes' => [
             'label' => 'Custom Child Menu 2',
             'navID' => 100,
-          ),
+          ],
           'child' => NULL,
-        ),
-      ),
-    );
+        ],
+      ],
+    ];
 
     $output = $input;
     CRM_Core_BAO_Navigation::fixNavigationMenu($output);
@@ -243,30 +243,30 @@ class CRM_Core_BAO_NavigationTest extends CiviUnitTestCase {
   }
 
   public function testFixNavigationMenu_inferIDs_deep() {
-    $input[10] = array(
-      'attributes' => array(
+    $input[10] = [
+      'attributes' => [
         'label' => 'Custom Menu Entry',
         'parentID' => NULL,
         'navID' => 10,
         'active' => 1,
-      ),
-      'child' => array(
-        '0' => array(
-          'attributes' => array(
+      ],
+      'child' => [
+        '0' => [
+          'attributes' => [
             'label' => 'Custom Child Menu',
-          ),
-          'child' => array(
-            '100' => array(
-              'attributes' => array(
+          ],
+          'child' => [
+            '100' => [
+              'attributes' => [
                 'label' => 'Custom Child Menu 2',
                 'navID' => 100,
-              ),
+              ],
               'child' => NULL,
-            ),
-          ),
-        ),
-      ),
-    );
+            ],
+          ],
+        ],
+      ],
+    ];
 
     $output = $input;
     CRM_Core_BAO_Navigation::fixNavigationMenu($output);
@@ -290,7 +290,7 @@ class CRM_Core_BAO_NavigationTest extends CiviUnitTestCase {
   public function testCheckPermissions() {
     $menuItem = [
       'permission' => 'access CiviCRM, access CiviContribute',
-      'operator' => 'AND'
+      'operator' => 'AND',
     ];
     CRM_Core_BAO_ConfigSetting::enableComponent('CiviContribute');
     CRM_Core_Config::singleton()->userPermissionClass->permissions = ['access CiviCRM', 'access CiviContribute'];
@@ -308,6 +308,23 @@ class CRM_Core_BAO_NavigationTest extends CiviUnitTestCase {
 
     CRM_Core_BAO_ConfigSetting::disableComponent('CiviContribute');
     $this->assertFalse(CRM_Core_BAO_Navigation::checkPermission($menuItem));
+
+    CRM_Core_BAO_ConfigSetting::enableComponent('CiviMail');
+    CRM_Core_Config::singleton()->userPermissionClass->permissions = ['access CiviMail', 'delete in CiviMail'];
+    $menuItem = [
+      'permission' => 'access CiviMail, delete in CiviMail',
+      'operator' => 'AND',
+    ];
+    $this->assertTrue(CRM_Core_BAO_Navigation::checkPermission($menuItem));
+    $menuItem['operator'] = 'OR';
+    $this->assertTrue(CRM_Core_BAO_Navigation::checkPermission($menuItem));
+    CRM_Core_Config::singleton()->userPermissionClass->permissions = ['delete in CiviMail'];
+    $this->assertTrue(CRM_Core_BAO_Navigation::checkPermission($menuItem));
+    CRM_Core_Config::singleton()->userPermissionClass->permissions = ['access CiviCRM'];
+    $this->assertFalse(CRM_Core_BAO_Navigation::checkPermission($menuItem));
+    CRM_Core_Config::singleton()->userPermissionClass->permissions = ['access CiviMail', 'delete in CiviMail'];
+    CRM_Core_BAO_ConfigSetting::disableComponent('CiviMail');
+    $this->assertFalse(CRM_Core_BAO_Navigation::checkPermission($menuItem));
   }
 
 }