X-Git-Url: https://vcs.fsf.org/?a=blobdiff_plain;f=src%2Fredirect.php;h=ff00fbdd9da80952ae6a8de5ae943a764ff06d3d;hb=bea235b53269ba2f56e9ab3f9a93ae4554c5868d;hp=c417b76a16dd18fd2c53edc228cc735ab542c9d3;hpb=b86f98e4d616f433403a56bfee1baab637c977bc;p=squirrelmail.git

diff --git a/src/redirect.php b/src/redirect.php
index c417b76a..ff00fbdd 100644
--- a/src/redirect.php
+++ b/src/redirect.php
@@ -5,12 +5,14 @@
  *
  * Derived from webmail.php by Ralf Kraudelt <kraude@wiwi.uni-rostock.de>
  *
- * @copyright &copy; 1999-2006 The SquirrelMail Project Team
+ * @copyright &copy; 1999-2009 The SquirrelMail Project Team
  * @license http://opensource.org/licenses/gpl-license.php GNU Public License
  * @version $Id$
  * @package squirrelmail
  */
-$sInitLocation = 'redirect';
+
+/** This is the redirect page */
+define('PAGE_NAME', 'redirect');
 
 /**
  * Include the SquirrelMail initialization file.
@@ -51,69 +53,69 @@ if (!isset($login_username)) {
     exit;
 }
 
-if (!sqsession_is_registered('user_is_logged_in')) {
-    do_hook('login_before', $null);
-
-    $onetimepad = OneTimePadCreate(strlen($secretkey));
-    $key = OneTimePadEncrypt($secretkey, $onetimepad);
-
-    /* remove redundant spaces */
-    $login_username = trim($login_username);
+do_hook('login_before', $null);
 
-    /* Verify that username and password are correct. */
-    if ($force_username_lowercase) {
-        $login_username = strtolower($login_username);
-    }
+$onetimepad = OneTimePadCreate(strlen($secretkey));
+$key = OneTimePadEncrypt($secretkey, $onetimepad);
 
-    $imapConnection = sqimap_login($login_username, $key, $imapServerAddress, $imapPort, 0);
-    /* From now on we are logged it. If the login failed then sqimap_login handles it */
-
-    /* regenerate the session id to avoid session hyijacking */
-    sqsession_destroy();
-    @sqsession_is_active();
-    session_regenerate_id();
-    /**
-     * The cookie part. session_start and session_regenerate_session normally set
-     * their own cookie. SquirrelMail sets another cookie which overwites the
-     * php cookies. The sqsetcookie function sets the cookie by using the header
-     * function which gives us full control how the cookie is set. We do that
-     * to add the HttpOnly cookie attribute which blocks javascript access on
-     * IE6 SP1.
-     */
-    sqsetcookie(session_name(),session_id(),false,$base_uri);
-    sqsetcookie('key', $key, false, $base_uri);
+/* remove redundant spaces */
+$login_username = trim($login_username);
 
-    sqsession_register($onetimepad, 'onetimepad');
+/* Case-normalise username if so desired */
+if ($force_username_lowercase) {
+    $login_username = strtolower($login_username);
+}
 
-    $sqimap_capabilities = sqimap_capability($imapConnection);
+/* Verify that username and password are correct. */
+$imapConnection = sqimap_login($login_username, $key, $imapServerAddress, $imapPort, 0);
+/* From now on we are logged it. If the login failed then sqimap_login handles it */
 
-    /* Server side sorting control */
-    if (isset($sqimap_capabilities['SORT']) && $sqimap_capabilities['SORT'] == true &&
-        isset($disable_server_sort) && $disable_server_sort) {
-        unset($sqimap_capabilities['SORT']);
-    }
+/* regenerate the session id to avoid session hyijacking */
+//FIXME!  IMPORTANT!  SOMEONE PLEASE EXPLAIN THE SECURITY CONCERN HERE; THIS session_destroy() BORKS ANY SESSION INFORMATION ADDED ON THE LOGIN PAGE (SPECIFICALLY THE SESSION RESTORE DATA, BUT ALSO ANYTHING ADDED BY PLUGINS, ETC)... I HAVE DISABLED THIS (AND NOTE THAT THE LOGIN PAGE ALREADY EXECUTES A session_destroy() (see includes/init.php)), SO PLEASE, WHOEVER ADDED THIS, PLEASE ANALYSE THIS SITUATION AND COMMENT ON IF IT IS OK LIKE THIS!!  WHAT HIJACKING ISSUES ARE WE SUPPOSED TO BE PREVENTING HERE?
+//sqsession_destroy();
+//@sqsession_is_active();
+//session_regenerate_id();
+/**
+* The cookie part. session_start and session_regenerate_session normally set
+* their own cookie. SquirrelMail sets another cookie which overwites the
+* php cookies. The sqsetcookie function sets the cookie by using the header
+* function which gives us full control how the cookie is set. We do that
+* to add the HttpOnly cookie attribute which blocks javascript access on
+* IE6 SP1.
+*/
+sqsetcookie(session_name(),session_id(),false,$base_uri);
+sqsetcookie('key', $key, false, $base_uri);
+
+sqsession_register($onetimepad, 'onetimepad');
+
+$sqimap_capabilities = sqimap_capability($imapConnection);
+
+/* Server side sorting control */
+if (isset($sqimap_capabilities['SORT']) && $sqimap_capabilities['SORT'] == true &&
+    isset($disable_server_sort) && $disable_server_sort) {
+    unset($sqimap_capabilities['SORT']);
+}
 
-    /* Thread sort control */
-    if (isset($sqimap_capabilities['THREAD']) && $sqimap_capabilities['THREAD'] == true &&
-        isset($disable_thread_sort) && $disable_thread_sort) {
-        unset($sqimap_capabilities['THREAD']);
-    }
+/* Thread sort control */
+if (isset($sqimap_capabilities['THREAD']) && $sqimap_capabilities['THREAD'] == true &&
+    isset($disable_thread_sort) && $disable_thread_sort) {
+    unset($sqimap_capabilities['THREAD']);
+}
 
-    sqsession_register($sqimap_capabilities, 'sqimap_capabilities');
-    $delimiter = sqimap_get_delimiter ($imapConnection);
+sqsession_register($sqimap_capabilities, 'sqimap_capabilities');
+$delimiter = sqimap_get_delimiter ($imapConnection);
 
-    if (isset($sqimap_capabilities['NAMESPACE']) && $sqimap_capabilities['NAMESPACE'] == true) {
-        $namespace = sqimap_get_namespace($imapConnection);
-        sqsession_register($namespace, 'sqimap_namespace');
-    }
+if (isset($sqimap_capabilities['NAMESPACE']) && $sqimap_capabilities['NAMESPACE'] == true) {
+    $namespace = sqimap_get_namespace($imapConnection);
+    sqsession_register($namespace, 'sqimap_namespace');
+}
 
-    sqimap_logout($imapConnection);
-    sqsession_register($delimiter, 'delimiter');
+sqimap_logout($imapConnection);
+sqsession_register($delimiter, 'delimiter');
 
-    $username = $login_username;
-    sqsession_register ($username, 'username');
-    do_hook('login_verified', $null);
-}
+$username = $login_username;
+sqsession_register ($username, 'username');
+do_hook('login_verified', $null);
 
 /* Set the login variables. */
 $user_is_logged_in = true;
@@ -129,13 +131,17 @@ $attachment_common_types_parsed = array();
 sqsession_register($attachment_common_types, 'attachment_common_types');
 sqsession_register($attachment_common_types_parsed, 'attachment_common_types_parsed');
 
-$debug = false;
-
 if ( sqgetGlobalVar('HTTP_ACCEPT', $http_accept, SQ_SERVER) &&
     !isset($attachment_common_types_parsed[$http_accept]) ) {
-    attachment_common_parse($http_accept, $debug);
+    attachment_common_parse($http_accept);
 }
 
+// having just logged in, need to synch the template file cache
+// so the right template set is displayed (per user prefs)
+require(SM_PATH . 'include/load_prefs.php');
+global $sTemplateID;
+Template::cache_template_file_hierarchy($sTemplateID, TRUE);
+
 /* Complete autodetection of Javascript. */
 checkForJavascript();
 
@@ -144,15 +150,18 @@ $redirect_url = $location . '/webmail.php';
 
 if ( sqgetGlobalVar('session_expired_location', $session_expired_location, SQ_SESSION) ) {
     sqsession_unregister('session_expired_location');
-    if ( strpos($session_expired_location, 'compose.php') !== FALSE ) {
+    if ( $session_expired_location == 'compose' ) {
         $compose_new_win = getPref($data_dir, $username, 'compose_new_win', 0);
         if ($compose_new_win) {
-            // do not prefix $location here because $session_expired_location is set to PHP_SELF
+            // do not prefix $location here because $session_expired_location is set to the PAGE_NAME
             // of the last page
-            $redirect_url = $session_expired_location;
+            $redirect_url = $location . '/' . $session_expired_location . '.php';
         } else {
-            $redirect_url = $location.'/webmail.php?right_frame='.urldecode($session_expired_location);
+            $redirect_url = $location . '/webmail.php?right_frame=' . urlencode($session_expired_location . '.php');
         }
+    } else if ($session_expired_location != 'webmail' 
+            && $session_expired_location != 'left_main') {
+        $redirect_url = $location . '/webmail.php?right_frame=' . urlencode($session_expired_location . '.php');
     }
     unset($session_expired_location);
 }
@@ -169,11 +178,9 @@ exit;
 
 /* --------------------- end main ----------------------- */
 
-function attachment_common_parse($str, $debug) {
+function attachment_common_parse($str) {
     global $attachment_common_types, $attachment_common_types_parsed;
 
-    $attachment_common_types_parsed[$str] = true;
-
     /*
      * Replace ", " with "," and explode on that as Mozilla 1.x seems to
      * use "," to seperate whilst IE, and earlier versions of Mozilla use
@@ -185,12 +192,15 @@ function attachment_common_parse($str, $debug) {
 
     foreach ($types as $val) {
         // Ignore the ";q=1.0" stuff
-        if (strpos($val, ';') !== false)
+        if (strpos($val, ';') !== false) {
             $val = substr($val, 0, strpos($val, ';'));
-
+        }
         if (! isset($attachment_common_types[$val])) {
             $attachment_common_types[$val] = true;
         }
     }
     sqsession_register($attachment_common_types, 'attachment_common_types');
+
+    /* mark as parsed */
+    $attachment_common_types_parsed[$str] = true;
 }