X-Git-Url: https://vcs.fsf.org/?a=blobdiff_plain;f=release-notes%2F5.35.0.md;h=fb3c2d1346a8652b34d16f9e0ccd6a50409f1780;hb=8d77776979ae4928ace4ced2301f3d7a19729338;hp=07dafa5fef935a9e7732c53e14e0a44e136b0275;hpb=c50386c1dad04afb31b7597237756116d604b8a1;p=civicrm-core.git diff --git a/release-notes/5.35.0.md b/release-notes/5.35.0.md index 07dafa5fef..fb3c2d1346 100644 --- a/release-notes/5.35.0.md +++ b/release-notes/5.35.0.md @@ -13,315 +13,652 @@ Released March 3, 2021 | *Does this version...?* | | |:--------------------------------------------------------------- |:-------:| -| Fix security vulnerabilities? | | -| Change the database schema? | | -| Alter the API? | | -| Require attention to configuration options? | | -| Fix problems installing or upgrading to a previous version? | | -| Introduce features? | | -| Fix bugs? | | +| Fix security vulnerabilities? | no | +| **Change the database schema?** | **yes** | +| **Alter the API?** | **yes** | +| **Require attention to configuration options?** | **yes** | +| **Fix problems installing or upgrading to a previous version?** | **yes** | +| **Introduce features?** | **yes** | +| **Fix bugs?** | **yes** | ## Features ### Core CiviCRM -- **crm- Missing Summary ([19325](https://github.com/civicrm/civicrm-core/pull/19325))** +- **Improve activity import to support updates (Work Towards + [dev/core#2308](https://lab.civicrm.org/dev/core/-/issues/2308): + [19439](https://github.com/civicrm/civicrm-core/pull/19439))** + + Ensures when importing activities, activity fields are not required if the + activity id is present, so that one can update existing activities via import. + +- **Proposal - make 5.33 the last CiviCRM version to support php 7.1 (agreed) + and mysql 5.6 (deferred) (& equivalent MariaDB version) (Work Towards + [dev/core#2204](https://lab.civicrm.org/dev/core/-/issues/2204): + [126](https://github.com/civicrm/civicrm-backdrop/pull/126), + [637](https://github.com/civicrm/civicrm-drupal/pull/637), + [238](https://github.com/civicrm/civicrm-wordpress/pull/238) and + [19390](https://github.com/civicrm/civicrm-core/pull/19390))** + + Update the minimum php install version to be 7.2. + +- **Add explicit box-sizing to crm-flex-box style + ([19325](https://github.com/civicrm/civicrm-core/pull/19325))** + + Ensures consistent box sizing when using the new `crm-flex-box` css class, + for consistency with or without Bootstrap 3. + +- **Search-kit - better user experience for bulk updates + ([dev/core#2310](https://lab.civicrm.org/dev/core/-/issues/2310): + [19425](https://github.com/civicrm/civicrm-core/pull/19425))** + + Adds a batch system to search kit. This avoids server timeouts, and improves + the user experience. + +- **Searchkit - separate calls for results & count + ([dev/core#2312](https://lab.civicrm.org/dev/core/-/issues/2312): + [19426](https://github.com/civicrm/civicrm-core/pull/19426))** + + Improves SearchKit results loading time in the admin UI. + +- **Searchkit - activity record type not intuitive + ([dev/core#2313](https://lab.civicrm.org/dev/core/-/issues/2313): + [19429](https://github.com/civicrm/civicrm-core/pull/19429))** + + Makes joins in SearchKit more intuitive by automatically adding commonly-used + default conditions. + +- **SearchKit: Add support for multi-record custom field groups + ([19452](https://github.com/civicrm/civicrm-core/pull/19452))** + + Adds support in SearchKit for multi-record custom field group pseudo-entities + to be added to the search as joins. + +- **Modifying lists of Country/StateProvince/County (Work Towards + [dev/core#2329](https://lab.civicrm.org/dev/core/-/issues/2329): + [19448](https://github.com/civicrm/civicrm-core/pull/19448))** + + Adds an `is_active` field to Country, StateProvince and County elements so + that they can be disabled. + +- **APIv4 - Enable getFields to find fields across implicit FK joins + ([19516](https://github.com/civicrm/civicrm-core/pull/19516))** + + Makes it possible to return fields from other entities using APIv4. + +- **Add v4 pledge api + ([19297](https://github.com/civicrm/civicrm-core/pull/19297))** + + Adds the Pledge entity to APIv4. + +- **Add pledge payment api + ([19436](https://github.com/civicrm/civicrm-core/pull/19436))** + + Adds the Pledge Payment entity to APIv4. + +- **Payment API - Add description of `order_reference` parameter + ([19449](https://github.com/civicrm/civicrm-core/pull/19449))** + + Adds a spec for the `Payment.order_reference` parameter so that is shows up in + the API explorer and is a little more discoverable. + +- **API Explorer - Fix URL encoding in REST examples + ([19450](https://github.com/civicrm/civicrm-core/pull/19450))** + + Improves the REST examples generated in "Support => Developer => Api Explorer + v3". + +- **Search Builder - Enhance UI with Select2 and EntityRef + ([19471](https://github.com/civicrm/civicrm-core/pull/19471))** + + Improves the UI of Search Builder (the classic one in core, not the new Search + Kit extension) by using Select2 dropdowns for selecting options & + autocompleting contacts, events, etc instead of needing to enter numeric ids. + +- **Add "label_field" metadata to entities + ([19504](https://github.com/civicrm/civicrm-core/pull/19504) and + [19546](https://github.com/civicrm/civicrm-core/pull/19546))** + + Adds a "label_field" metadata to the schema for entities so that one can know + how a entity should be displayed by looking at the metadata. + +- **Select2 - Improve styles for disabled, loading elements + ([19430](https://github.com/civicrm/civicrm-core/pull/19430))** + + Improves Select2 user experience in Greenwich. + +- **Tabbed interface for organizing afforms by type + ([19395](https://github.com/civicrm/civicrm-core/pull/19395))** + + Creates afform types and a tabbed interface in the Admin section, and adds + support for embedding search displays into afform fieldsets. + +- **Add setting default to speed up cache flush + ([19383](https://github.com/civicrm/civicrm-core/pull/19383))** + + Adds a define to civicrm.settings.php that speeds up cache flushes + +- **Add pseudoconstant for Relationship.relationship_type_id + ([19278](https://github.com/civicrm/civicrm-core/pull/19278))** + + Updates the relationship schema to add a pseudoconstant to the + relationship_type_id field. + +### CiviContribute + +- **Unhide contributioncancelactions core extension + ([19500](https://github.com/civicrm/civicrm-core/pull/19500))** + + Makes the Contributioncancelactions extension visible and disabling it + supported. + +### CiviMail + +- **Support tracking URLs with tokens in query strings + ([dev/mail#81](https://lab.civicrm.org/dev/mail/-/issues/81): + [19386](https://github.com/civicrm/civicrm-core/pull/19386))** + + When delivering a mail-blast, Flexmailer replaces most URLs with trackable + URLs. This expands tracking support for URLs that include tokens. + +### Drupal Integration + +- **allow filtering by empty event end, registration start, registration end + dates ([634](https://github.com/civicrm/civicrm-drupal/pull/634))** + + Makes it possible to filter by empty event date fields in views. + +- **Advice in failure message is out of date + ([633](https://github.com/civicrm/civicrm-drupal/pull/633))** + + Improves error message when unable to load CRM/Core/Config.php. ## Bugs resolved ### Core CiviCRM -- **5.34 ([19521](https://github.com/civicrm/civicrm-core/pull/19521))** +- **search on relationship and case + ([18779](https://github.com/civicrm/civicrm-core/pull/18779))** -- **Afform GUI - Fix errors when creating & saving blocks ([19519](https://github.com/civicrm/civicrm-core/pull/19519))** + Ensures Advanced search filters correctly when displaying related contacts and + searching with case parameters. -- **dev/core#2340 Skip rather than fail on bad menu item ([19464](https://github.com/civicrm/civicrm-core/pull/19464))** +- **Don't check for .git in the isDevelopment() function + ([dev/core#2241](https://lab.civicrm.org/dev/core/-/issues/2241): + [19361](https://github.com/civicrm/civicrm-core/pull/19361))** -- **APIv4 - Fix bug when using relative date filters in ON clause of a join ([19514](https://github.com/civicrm/civicrm-core/pull/19514))** + Deprecates direct calls to `isDevelopment()`. -- **Override the DrupalBase getUserObject function with a Drupal8/9 compa… ([19517](https://github.com/civicrm/civicrm-core/pull/19517))** +- **Adding Contacts to a New Group via Manage Groups Page Failure + ([dev/core#2333](https://lab.civicrm.org/dev/core/-/issues/2333): + [19472](https://github.com/civicrm/civicrm-core/pull/19472))** -- **APIv4 - Enable getFields to find fields across implicit FK joins ([19516](https://github.com/civicrm/civicrm-core/pull/19516))** + Fixes an issue when creating a group from a letter page of search results. -- **[REF] Extract logical functions from sendTemplate ([19510](https://github.com/civicrm/civicrm-core/pull/19510))** +- **Oauth Redirect URL reporterror_civicrm_handler + ([dev/core#2350](https://lab.civicrm.org/dev/core/-/issues/2350): + [19492](https://github.com/civicrm/civicrm-core/pull/19492))** -- **[REF] Move sendNotification out of recur, remove unused related_contact ([19443](https://github.com/civicrm/civicrm-core/pull/19443))** + Ensures when using the Oauth extension, setting a fatalErrorHandler does not + override the redirect url. -- **[REF] Remove invalid attempt to load contriution id from invoiceID ([19511](https://github.com/civicrm/civicrm-core/pull/19511))** +- **Search Kit: Search kit, contribution search - financial type field is odd + ([dev/core#2349](https://lab.civicrm.org/dev/core/-/issues/2349) and + [dev/core#2347](https://lab.civicrm.org/dev/core/-/issues/2347): + [19489](https://github.com/civicrm/civicrm-core/pull/19489))** -- **[REF] Stop passing contributionPageID to isEmailReceipt ([19498](https://github.com/civicrm/civicrm-core/pull/19498))** + Fixes two SearchKit bugs: -- **dev/core#2355 - E_NOTICE on Manage Contribution and Manage Event listings ([19515](https://github.com/civicrm/civicrm-core/pull/19515))** + - Contribution Search, financial type return empty + - Preview button on table display form not working -- **Afform - Misc tweaks, validation & bug fixes ([19496](https://github.com/civicrm/civicrm-core/pull/19496))** +- **Afform - Misc tweaks, validation & bug fixes + ([19496](https://github.com/civicrm/civicrm-core/pull/19496))** -- **Move require once in api kernel to support edge cases ([19513](https://github.com/civicrm/civicrm-core/pull/19513))** + Adds basic validation to server_route in the Afform GUI, only permitting + paths beginning with "civicrm/". Also re-labels the menu item and page + title to "Form Builder" and resets server_route and is_dashlet when cloning. + And fixes several bugs in Afform & Search Kit. -- **dev/core#2350 - Oauth extension - Setting a fatalErrorHandler might override the redirect url because typo ([19492](https://github.com/civicrm/civicrm-core/pull/19492))** +- **Afform - Fix form submit button + ([19460](https://github.com/civicrm/civicrm-core/pull/19460))** -- **[REF] Standardise methods of determining isTest ([19417](https://github.com/civicrm/civicrm-core/pull/19417))** + Ensures clicking Submit on an afform actually submits the form. -- **Remove another use of loadRelatedObjects() function ([19505](https://github.com/civicrm/civicrm-core/pull/19505))** +- **Afform GUI enhancements & Search Kit integration + ([19455](https://github.com/civicrm/civicrm-core/pull/19455))** -- **dev/core#2206 Unhide contributioncancelactions core extension ([19500](https://github.com/civicrm/civicrm-core/pull/19500))** + Fixes errors in afform GUI when creating a new block from the admin screen and + when clicking "Save as Block" -- **Comment intent to remove call to transition components ([19507](https://github.com/civicrm/civicrm-core/pull/19507))** +- **Afform - Drop directive support for attribute, only support elements as + afforms ([19438](https://github.com/civicrm/civicrm-core/pull/19438) and + [19670](https://github.com/civicrm/civicrm-core/pull/19670))** -- **CRM_Core_BAO_MessageTemplate::sendReminder() is not used anywhere ([19502](https://github.com/civicrm/civicrm-core/pull/19502))** + Afform no longer responds to attributes set for standard HTML elements; you + must use a special element to invoke an Afform. -- **Add "labelField" metadata to entities ([19504](https://github.com/civicrm/civicrm-core/pull/19504))** +- **Greenwich - fix list margin added by some CMS themes + ([19423](https://github.com/civicrm/civicrm-core/pull/19423))** -- **Use exceptions when enabling case component / checking for 'CREATE VIEW' permissions ([19503](https://github.com/civicrm/civicrm-core/pull/19503))** + Fixes a style conflict between some CMS themes and Greenwich, causing tabs to + shift to the right. -- **Remove always true if ([19499](https://github.com/civicrm/civicrm-core/pull/19499))** +- **Flag that Embedded Activity Revisions setting is unsupported and deprecated + ([19422](https://github.com/civicrm/civicrm-core/pull/19422))** -- **dev/core#2206 Move cancel pledge into Contribution.create and fix ([19289](https://github.com/civicrm/civicrm-core/pull/19289))** + Adds more documentation to the 'Enable Embedded Activity Revisions' setting to + make it explicit that it is deprecated. -- **5.34 ([19493](https://github.com/civicrm/civicrm-core/pull/19493))** +- **Use php to require an array + ([19370](https://github.com/civicrm/civicrm-core/pull/19370))** -- **NFC Minor code cleanup to contribution pages ([19468](https://github.com/civicrm/civicrm-core/pull/19468))** + Removes is_array check in favor of php strict typing. -- **Token Processor: fix PHP syntax for purifyHTML ([19490](https://github.com/civicrm/civicrm-core/pull/19490))** +- **Fix rendering of Dashlet placeholder + ([dev/core#2306](https://lab.civicrm.org/dev/core/-/issues/2306): + [19413](https://github.com/civicrm/civicrm-core/pull/19413))** -- **Search Kit: Misc bug fixes ([19489](https://github.com/civicrm/civicrm-core/pull/19489))** + Prevents panel jumping when dragging dashlets. -- **5.34 ([19487](https://github.com/civicrm/civicrm-core/pull/19487))** +- **Dashboard: Improve status messages when moving/deleting dashlets + ([19358](https://github.com/civicrm/civicrm-core/pull/19358))** -- **Issue #2352: fix Views integration suggestion ([19491](https://github.com/civicrm/civicrm-core/pull/19491))** + Ensures a in-progress message is displayed when moving/deleting dashlets. -- **Greenwich: Fix BS3 conflict with html5 search clear button ([19461](https://github.com/civicrm/civicrm-core/pull/19461))** +- **Using %1%2 in ts() generates confusing output in transifex + ([dev/translation#64](https://lab.civicrm.org/dev/translation/-/issues/64): + [19453](https://github.com/civicrm/civicrm-core/pull/19453))** -- **[NFC] Update composer.lock ([19485](https://github.com/civicrm/civicrm-core/pull/19485))** +- **Upgrader (5.34) - Handle unsavable characters in decoded SMTP password + ([19711](https://github.com/civicrm/civicrm-core/pull/19711))** -- **[REF] Remove copy & paste code from Activity mapping form ([19488](https://github.com/civicrm/civicrm-core/pull/19488))** + This resolves upgrade problems as older sites upgrade through 5.34.0, have + encrypted SMTP credentials, and have 8-bit characters. -- **Search Kit - Fix display pager and improve error handling ([19479](https://github.com/civicrm/civicrm-core/pull/19479))** +- **Issue with importing to checkbox type fields where label is the same as + database value (may affect other types too) + ([dev/core#866](https://lab.civicrm.org/dev/core/-/issues/866) and + [dev/core#1318](https://lab.civicrm.org/dev/core/-/issues/1318): + [19111](https://github.com/civicrm/civicrm-core/pull/19111))** -- **Merge 5.34 to master ([19484](https://github.com/civicrm/civicrm-core/pull/19484))** +- **Logging tables shown as 'different' incorrectly after upgrading to MariaDB + 10.4.x ([dev/core#2305](https://lab.civicrm.org/dev/core/-/issues/2305): + [19412](https://github.com/civicrm/civicrm-core/pull/19412))** -- **dev/core#2329 Add is_active field to Country/StateProvince/County ([19448](https://github.com/civicrm/civicrm-core/pull/19448))** +- **Mapping a contact gives invalid argument supplied. + ([dev/core#2307](https://lab.civicrm.org/dev/core/-/issues/2307): + [19414](https://github.com/civicrm/civicrm-core/pull/19414))** -- **Afform - Fix form submit button ([19460](https://github.com/civicrm/civicrm-core/pull/19460))** +- **Inconsistent line breaks on custom field edit page for description text + ([dev/core#2328](https://lab.civicrm.org/dev/core/-/issues/2328): + [19444](https://github.com/civicrm/civicrm-core/pull/19444))** -- **dev/core#2333 Fix issue when clicking on alpha links from 'amtg' search ([19472](https://github.com/civicrm/civicrm-core/pull/19472))** +- **Creating an afform without civicrm/ in the url breaks the site + ([dev/core#2340](https://lab.civicrm.org/dev/core/-/issues/2340): + [19464](https://github.com/civicrm/civicrm-core/pull/19464))** -- **[NFC] Fix PHP 7.4 Syntax issue in Afform HTML Extension ([19477](https://github.com/civicrm/civicrm-core/pull/19477))** +- **Afform api explorer: has_local, has_base do not present as bool + ([dev/core#2341](https://lab.civicrm.org/dev/core/-/issues/2341): + [19465](https://github.com/civicrm/civicrm-core/pull/19465))** -- **Afform GUI enhancements & Search Kit integration ([19455](https://github.com/civicrm/civicrm-core/pull/19455))** +- **APIv4 - Fix bug when using relative date filters in ON clause of a join + ([19514](https://github.com/civicrm/civicrm-core/pull/19514))** -- **Search Builder - Enhance UI with Select2 and EntityRef ([19471](https://github.com/civicrm/civicrm-core/pull/19471))** +- **Search Kit - Fix display pager and improve error handling + ([19479](https://github.com/civicrm/civicrm-core/pull/19479))** -- **Show disabled membership types on contact tab ([19431](https://github.com/civicrm/civicrm-core/pull/19431))** +- **Afform - delete unused, nonfunctional apis + ([19432](https://github.com/civicrm/civicrm-core/pull/19432))** -- **API Explorer - Fix URL encoding in REST examples ([19450](https://github.com/civicrm/civicrm-core/pull/19450))** +- **Afform GUI - Fix errors when creating & saving blocks + ([19519](https://github.com/civicrm/civicrm-core/pull/19519))** -- **dev/core#2341 Set data_type on various fields in Afform API ([19465](https://github.com/civicrm/civicrm-core/pull/19465))** +- **Greenwich: Fix BS3 conflict with html5 search clear button + ([19461](https://github.com/civicrm/civicrm-core/pull/19461))** -- **REF Move buildMembershipBlock function from ContributionPage to Main/Confirm/Thankyou page ([19467](https://github.com/civicrm/civicrm-core/pull/19467))** +- **Move require once in api kernel to support edge cases + ([19513](https://github.com/civicrm/civicrm-core/pull/19513))** -- **5.34 ([19470](https://github.com/civicrm/civicrm-core/pull/19470))** +- **Token Processor: fix PHP syntax for purifyHTML + ([19490](https://github.com/civicrm/civicrm-core/pull/19490))** -- **dev/core#2310 Searchkit - Perform bulk updates in batches; improve user feedback. ([19425](https://github.com/civicrm/civicrm-core/pull/19425))** +- **Do not set source_contact_id in summary function + ([19456](https://github.com/civicrm/civicrm-core/pull/19456))** -- **dev/core#2339 - Fix failing relativeDate test ([19462](https://github.com/civicrm/civicrm-core/pull/19462))** +- **Fix missing translate tag + ([19451](https://github.com/civicrm/civicrm-core/pull/19451))** -- **Update contributor-key.yml ([19459](https://github.com/civicrm/civicrm-core/pull/19459))** +- **composer.json - Ignore unused variants of Monaco ("dev"/"esm") + ([19433](https://github.com/civicrm/civicrm-core/pull/19433))** -- **Afform - Drop directive support for attribute, only support elements as afforms ([19438](https://github.com/civicrm/civicrm-core/pull/19438))** +- **"Admin => Misc" - Fix validation of "Maximum File Size" + ([19382](https://github.com/civicrm/civicrm-core/pull/19382))** -- **dev/core#2305 Fix schema differences in MariaDB 10.2.x+ ([19412](https://github.com/civicrm/civicrm-core/pull/19412))** +- **Fix Redis deprecated warning + ([19593](https://github.com/civicrm/civicrm-core/pull/19593))** -- **Do not set source_contact_id in summary function ([19456](https://github.com/civicrm/civicrm-core/pull/19456))** +- **SearchKit : use of rows in query cause mysql errors + ([dev/core#2360](https://lab.civicrm.org/dev/core/-/issues/2360): + [19653](https://github.com/civicrm/civicrm-core/pull/19653)) -- **SearchKit: Add support for multi-record custom field groups ([19452](https://github.com/civicrm/civicrm-core/pull/19452))** +- **Decimal Separator - Incorrect format in some views and editions + ([dev/core#2394](https://lab.civicrm.org/dev/core/-/issues/2394): + [19685](https://github.com/civicrm/civicrm-core/pull/19685) and + [19692](https://github.com/civicrm/civicrm-core/pull/19692))** -- **dev/core#866, dev/core#1318 Fix failure to import checkboxes for activities ([19111](https://github.com/civicrm/civicrm-core/pull/19111))** +- **Account IIF Export Amount Format improper + ([dev/financial#166](https://lab.civicrm.org/dev/financial/-/issues/166): + [19680](https://github.com/civicrm/civicrm-core/pull/19680))** -- **[dev/financial#164] Cannot edit contribution with revenue recognition date in a past year ([19454](https://github.com/civicrm/civicrm-core/pull/19454))** + This resolves inconsistency in the money formatting where the currency symbol + would be added inappropriately. -- **Update TemplateList.tpl ([19451](https://github.com/civicrm/civicrm-core/pull/19451))** +- **Some Multi-Select Custom Fields cannot be saved + ([dev/core#2423](https://lab.civicrm.org/dev/core/-/issues/2423): + [19698](https://github.com/civicrm/civicrm-core/pull/19698))** -- **dev/core#2308 do not require fields if activity_id is present ([19439](https://github.com/civicrm/civicrm-core/pull/19439))** + This resolves the problem that multi-select fields with integer, number, or + money data types could not have data stored in them. -- **dev/translation#64 - Using %1%2 seems to confuse transifex - System status check Cms.php ([19453](https://github.com/civicrm/civicrm-core/pull/19453))** +- **Dashboard Query failed to detect existing record for contact + ([dev/core#2426](https://lab.civicrm.org/dev/core/-/issues/2426): + [19694](https://github.com/civicrm/civicrm-core/pull/19694))** -- **Payment API - Add description of `order_reference` parameter ([19449](https://github.com/civicrm/civicrm-core/pull/19449))** + This resolves a crash on the CiviCRM dashboard if a user lacks the permission + to view their own contact. -- **Remove unnecessary call to error_reporting in drupal 7 integration code ([19445](https://github.com/civicrm/civicrm-core/pull/19445))** +### CiviCase -- **dev/core#2326 - Status check for invalid case type `name`s ([19441](https://github.com/civicrm/civicrm-core/pull/19441))** +- **Custom Field of type Integer that uses Radio Buttons as Input Type in + combination with search range scrambles Case Report Search + ([dev/core#2288](https://lab.civicrm.org/dev/core/-/issues/2288): + [19339](https://github.com/civicrm/civicrm-core/pull/19339))** -- **REF Permit installing of replacement extensions during upgrade for ob… ([19391](https://github.com/civicrm/civicrm-core/pull/19391))** +- **Upgrading an old site with spaces in the case type names and external xml + files leads to difficult to resolve status messages + ([dev/core#2326](https://lab.civicrm.org/dev/core/-/issues/2326): + [19441](https://github.com/civicrm/civicrm-core/pull/19441))** -- **dev/core#2327 - In the sample casetype xml files the is the label not the name ([19442](https://github.com/civicrm/civicrm-core/pull/19442))** +- **Sample xml casetype configuration files have label instead of name in the + name ([dev/core#2327](https://lab.civicrm.org/dev/core/-/issues/2327): + [19442](https://github.com/civicrm/civicrm-core/pull/19442))** -- **Fix PHP notice if membershipBlock is not defined ([19447](https://github.com/civicrm/civicrm-core/pull/19447))** +- **Use exceptions when enabling case component / checking for 'CREATE VIEW' + permissions ([19503](https://github.com/civicrm/civicrm-core/pull/19503))** -- **update contributor-key.yml and CONTRIBUTORS.txt file ([19446](https://github.com/civicrm/civicrm-core/pull/19446))** +### CiviContribute -- **dev/core#2328 - Make the description line breaks on the custom field edit form consistent ([19444](https://github.com/civicrm/civicrm-core/pull/19444))** +- **Fix pledge action on failed/ cancelled contribution + ([dev/core#2206](https://lab.civicrm.org/dev/core/-/issues/2206): + [19289](https://github.com/civicrm/civicrm-core/pull/19289))** -- **[REF] Remove objects var from PaypalProIPN ([19440](https://github.com/civicrm/civicrm-core/pull/19440))** + Ensures that Pledge payments are correctly updated when a contribution is + cancelled or fails. -- **Add pledge payment api ([19436](https://github.com/civicrm/civicrm-core/pull/19436))** +- **Undefined index when putting in a contribution thank-you date without a time + ([dev/core#2297](https://lab.civicrm.org/dev/core/-/issues/2297): + [19388](https://github.com/civicrm/civicrm-core/pull/19388))** -- **[REF] Remove seemingly unreachable attempt to format activity_date_time ([19437](https://github.com/civicrm/civicrm-core/pull/19437))** +- **Cannot edit contribution with revenue recognition date in a past year + ([dev/financial#164](https://lab.civicrm.org/dev/financial/-/issues/164): + [19454](https://github.com/civicrm/civicrm-core/pull/19454))** -- **dev/wordpress#86 Ensure that the list of groups in search or on the n… ([19372](https://github.com/civicrm/civicrm-core/pull/19372))** +- **Notice: Undefined property: CRM_Core_DAO::$_context in + CRM_Utils_PagerAToZ::createLinks() on contribution page listing + ([dev/core#2355](https://lab.civicrm.org/dev/core/-/issues/2355): + [19515](https://github.com/civicrm/civicrm-core/pull/19515))** -- **5.34 ([19435](https://github.com/civicrm/civicrm-core/pull/19435))** +- **Set contribution_page_id from template contribution + ([19362](https://github.com/civicrm/civicrm-core/pull/19362))** -- **dev/core#2312 SearchKit - Improve results loading time in admin UI ([19426](https://github.com/civicrm/civicrm-core/pull/19426))** +- **Fix pledge to not use pass-by-reference + ([19400](https://github.com/civicrm/civicrm-core/pull/19400))** -- **dev/core#2313 SearchKit - Default join conditions ([19429](https://github.com/civicrm/civicrm-core/pull/19429))** +### CiviMail -- **Flag that Embedded Activity Revisions setting is unsupported and deprecated ([19422](https://github.com/civicrm/civicrm-core/pull/19422))** +- **Update permissions for "CiviCRM Admin Menu -> Mailings -> Message Templates" + nav item ([19342](https://github.com/civicrm/civicrm-core/pull/19342))** -- **composer.json - Ignore unused variants of Monaco ("dev"/"esm") ([19433](https://github.com/civicrm/civicrm-core/pull/19433))** + Updates the permissions for the "CiviCRM Admin Menu -> Mailings -> Message + Templates" navigation item so that if the user has any of the following + permissions they can view it: -- **Select2 - Improve styles for disabled, loading elements ([19430](https://github.com/civicrm/civicrm-core/pull/19430))** + - edit user-driven message templates + - edit system workflow message templates + - edit message templates -- **Afform - delete unused, nonfunctional apis ([19432](https://github.com/civicrm/civicrm-core/pull/19432))** +- **When two contacts, Contact A and Contact B have the same email address, if + Contact A is deleted then Contact B is incorrectly excluded from mailings, + does not receive emails + ([19360](https://github.com/civicrm/civicrm-core/pull/19360))** -- **dev/core#2114 - Changes in upper/lower case or accents are not logged when using trigger-based logging ([18782](https://github.com/civicrm/civicrm-core/pull/18782))** +### CiviMembership -- **[Test framework] Prevent intermittently failing relationship test ([19424](https://github.com/civicrm/civicrm-core/pull/19424))** +- **Show disabled membership types on contact tab + ([19431](https://github.com/civicrm/civicrm-core/pull/19431) and + [19594](https://github.com/civicrm/civicrm-core/pull/19594))** -- **Greenwich - fix list margin added by some CMS themes ([19423](https://github.com/civicrm/civicrm-core/pull/19423))** +- **Fix PHP notice if membershipBlock is not defined + ([19447](https://github.com/civicrm/civicrm-core/pull/19447))** -- **(dev/mail#81) Flexmailer - Track click-throughs for URLs with tokens ([19386](https://github.com/civicrm/civicrm-core/pull/19386))** +### Backdrop Integration -- **dev/financial#148 fully deprecate loadObjects function ([19416](https://github.com/civicrm/civicrm-core/pull/19416))** +- **UF Settings page for Views CiviCRM integration should not have backticks for + Backdrop ([dev/core#2352](https://lab.civicrm.org/dev/core/-/issues/2352): + [19491](https://github.com/civicrm/civicrm-core/pull/19491))** -- **Bump socket.io from 2.3.0 to 2.4.1 ([19427](https://github.com/civicrm/civicrm-core/pull/19427))** +### Drupal Integration -- **dev/report#53: search on relationship and case ([18779](https://github.com/civicrm/civicrm-core/pull/18779))** +- **Override the DrupalBase getUserObject function with a Drupal8/9 compatible + version ([19517](https://github.com/civicrm/civicrm-core/pull/19517))** -- **Tabbed interface for organizing afforms by type ([19395](https://github.com/civicrm/civicrm-core/pull/19395))** + Fixes an error when using the APIv3 `User` entity on Drupal 9. -- **[REF] Remove some of those old php4 &s ([19419](https://github.com/civicrm/civicrm-core/pull/19419))** +- **Drupal7: civicrm_rules - Add/Remove contact from CiviCRM Group works with + deprecated method on removal + ([dev/drupal#65](https://lab.civicrm.org/dev/drupal/-/issues/65): + [580](https://github.com/civicrm/civicrm-drupal/pull/580))** -- **Add v4 pledge api ([19297](https://github.com/civicrm/civicrm-core/pull/19297))** +- **Drupal9: system_get_info() not available. CiviReport crash.** + ([dev/drupal#156](https://lab.civicrm.org/dev/drupal/-/issues/156): [#19725](https://github.com/civicrm/civicrm-core/pull/19725)) -- **Cleanup a couple of unnecessary references ([19420](https://github.com/civicrm/civicrm-core/pull/19420))** +- **Fix deceased date format + ([607](https://github.com/civicrm/civicrm-drupal/pull/607))** -- **[REF] Move related code to be together ([19418](https://github.com/civicrm/civicrm-core/pull/19418))** +### WordPress Integration -- **[REF] Simplify activity import validation ([19373](https://github.com/civicrm/civicrm-core/pull/19373))** +- **List of groups in search form and create new contact screen not respecting + ACLs ([dev/wordpress#86](https://lab.civicrm.org/dev/wordpress/-/issues/86): + [19372](https://github.com/civicrm/civicrm-core/pull/19372))** -- **[#REF] Cleanup recently added code fixing dev/core#2307 for the fact … ([19415](https://github.com/civicrm/civicrm-core/pull/19415))** +## Miscellany -- **dev/core#2303 Extract function to load the messageContent for a template ([19409](https://github.com/civicrm/civicrm-core/pull/19409))** +- **Bump socket.io from 2.3.0 to 2.4.1 + ([19427](https://github.com/civicrm/civicrm-core/pull/19427))** -- **Fix rendering of Dashlet placeholder ([19413](https://github.com/civicrm/civicrm-core/pull/19413))** +- **Afform - code refactoring for angular best practices + ([19352](https://github.com/civicrm/civicrm-core/pull/19352))** -- **Fix Issue 2307 ([19414](https://github.com/civicrm/civicrm-core/pull/19414))** +- **Token plan - what is it (Code Cleanup for + [dev/core#2303](https://lab.civicrm.org/dev/core/-/issues/2303): + [19409](https://github.com/civicrm/civicrm-core/pull/19409))** -- **[REF] Move instantiation of Order class to earlier in function ([19402](https://github.com/civicrm/civicrm-core/pull/19402))** +- **Deprecate BaseIPN functions validateData & LoadObject + ([dev/financial#148](https://lab.civicrm.org/dev/financial/-/issues/148): + [19416](https://github.com/civicrm/civicrm-core/pull/19416))** -- **Deprecate Pledge::add() function ([19411](https://github.com/civicrm/civicrm-core/pull/19411))** +- **Comment intent to remove call to transition components + ([19507](https://github.com/civicrm/civicrm-core/pull/19507))** -- **dev/core#2204 Bump Minimum install PHP 7.2 ([19390](https://github.com/civicrm/civicrm-core/pull/19390))** +- **CRM_Core_BAO_MessageTemplate::sendReminder() is not used anywhere + ([19502](https://github.com/civicrm/civicrm-core/pull/19502))** -- **Fix pledge to not use pass-by-reference ([19400](https://github.com/civicrm/civicrm-core/pull/19400))** +- **Move another deprecated utils function + ([19365](https://github.com/civicrm/civicrm-core/pull/19365))** -- **[REF] Fix Order class to not reload if already loaded ([19403](https://github.com/civicrm/civicrm-core/pull/19403))** +- **Deprecate Pledge::add() function + ([19411](https://github.com/civicrm/civicrm-core/pull/19411))** -- **Remove call to loadRelatedObjects ([19407](https://github.com/civicrm/civicrm-core/pull/19407))** +- **Cleanup a couple of unnecessary references + ([19420](https://github.com/civicrm/civicrm-core/pull/19420))** -- **[REF] Move code closer to where it is used ([19410](https://github.com/civicrm/civicrm-core/pull/19410))** +- **Update contributor-key.yml + ([19459](https://github.com/civicrm/civicrm-core/pull/19459))** -- **[NFC] Whitespace fix up ([19408](https://github.com/civicrm/civicrm-core/pull/19408))** +- **update contributor-key.yml and CONTRIBUTORS.txt file + ([19446](https://github.com/civicrm/civicrm-core/pull/19446))** -- **[Test] Extend new membership form to cover multi-line renew + minor cleanup ([19404](https://github.com/civicrm/civicrm-core/pull/19404))** +- **Remove unnecessary call to error_reporting in drupal 7 integration code + ([19445](https://github.com/civicrm/civicrm-core/pull/19445))** -- **[REF] Param simplification ([19406](https://github.com/civicrm/civicrm-core/pull/19406))** +- **Remove call to loadRelatedObjects + ([19407](https://github.com/civicrm/civicrm-core/pull/19407))** -- **[NFC] Preliminary cleanup ([19401](https://github.com/civicrm/civicrm-core/pull/19401))** +- **Remove always true if + ([19499](https://github.com/civicrm/civicrm-core/pull/19499))** -- **[REF] Minor cleanup on emailReceipt ([19405](https://github.com/civicrm/civicrm-core/pull/19405))** +- **Remove another use of loadRelatedObjects() function + ([19505](https://github.com/civicrm/civicrm-core/pull/19505))** -- **REF Ensure that when doing RLIKE BINARY the field is cast as BINARY t… ([19399](https://github.com/civicrm/civicrm-core/pull/19399))** +- **Test framework - API4 DateTest::testRelativeDateRanges will fail on the last + day of Jan, Mar, May, Aug, Oct + ([dev/core#2339](https://lab.civicrm.org/dev/core/-/issues/2339): + [19462](https://github.com/civicrm/civicrm-core/pull/19462))** -- **5.34 ([19393](https://github.com/civicrm/civicrm-core/pull/19393))** +- **[Test framework] Prevent intermittently failing relationship test + ([19424](https://github.com/civicrm/civicrm-core/pull/19424))** -- **dev/core#2297 - E_NOTICE on contribution thankyou_date_time since time component no longer a separate field ([19388](https://github.com/civicrm/civicrm-core/pull/19388))** +- **[Test] Extend new membership form to cover multi-line renew + minor cleanup + ([19404](https://github.com/civicrm/civicrm-core/pull/19404))** -- **Add setting default to speed up cache flush ([19383](https://github.com/civicrm/civicrm-core/pull/19383))** +- **[REF] Remove some of those old php4 &s + ([19419](https://github.com/civicrm/civicrm-core/pull/19419))** -- **dev/core#2288 - Alternative fix search range for select/radio custom fields - now disabling the combination ([19339](https://github.com/civicrm/civicrm-core/pull/19339))** +- **REF Move buildMembershipBlock function from ContributionPage to + Main/Confirm/Thankyou page + ([19467](https://github.com/civicrm/civicrm-core/pull/19467))** -- **"Admin => Misc" - Fix validation of "Maximum File Size" ([19382](https://github.com/civicrm/civicrm-core/pull/19382))** +- **REF Permit installing of replacement extensions during upgrade for ob… + ([19391](https://github.com/civicrm/civicrm-core/pull/19391))** -- **Afform - code refactoring for angular best practices ([19352](https://github.com/civicrm/civicrm-core/pull/19352))** +- **[REF] Remove objects var from PaypalProIPN + ([19440](https://github.com/civicrm/civicrm-core/pull/19440))** -- **5.34 ([19385](https://github.com/civicrm/civicrm-core/pull/19385))** +- **[REF] Remove seemingly unreachable attempt to format activity_date_time + ([19437](https://github.com/civicrm/civicrm-core/pull/19437))** -- **Add pseudoconstant for Relationship.relationship_type_id ([19278](https://github.com/civicrm/civicrm-core/pull/19278))** +- **[REF] Move related code to be together + ([19418](https://github.com/civicrm/civicrm-core/pull/19418))** -- **Move another deprecated utils function ([19365](https://github.com/civicrm/civicrm-core/pull/19365))** +- **[REF] Simplify activity import validation + ([19373](https://github.com/civicrm/civicrm-core/pull/19373))** -- **[NFC] minor code cleanups ([19366](https://github.com/civicrm/civicrm-core/pull/19366))** +- **[#REF] Cleanup recently added code fixing dev/core#2307 for the fact … + ([19415](https://github.com/civicrm/civicrm-core/pull/19415))** -- **5.34 ([19380](https://github.com/civicrm/civicrm-core/pull/19380))** +- **[REF] Move instantiation of Order class to earlier in function + ([19402](https://github.com/civicrm/civicrm-core/pull/19402))** -- **[NFC] Update contributor-key.yml with Ahed ([19378](https://github.com/civicrm/civicrm-core/pull/19378))** +- **[REF] Remove copy & paste code from Activity mapping form + ([19488](https://github.com/civicrm/civicrm-core/pull/19488))** -- **5.34 to master ([19375](https://github.com/civicrm/civicrm-core/pull/19375))** +- **[REF] Fix Order class to not reload if already loaded + ([19403](https://github.com/civicrm/civicrm-core/pull/19403))** -- **Use php to require an array ([19370](https://github.com/civicrm/civicrm-core/pull/19370))** +- **[REF] Move code closer to where it is used + ([19410](https://github.com/civicrm/civicrm-core/pull/19410))** -- **[NFC] Minor code cleanup ([19367](https://github.com/civicrm/civicrm-core/pull/19367))** +- **[REF] Param simplification + ([19406](https://github.com/civicrm/civicrm-core/pull/19406))** -- **[REF] Remove function that is the same as parent ([19369](https://github.com/civicrm/civicrm-core/pull/19369))** +- **[REF] Minor cleanup on emailReceipt + ([19405](https://github.com/civicrm/civicrm-core/pull/19405))** -- **[NFC] Move Upgrade for navgation from 5.34.alpha1 to 5.35.alpha1 as t… ([19364](https://github.com/civicrm/civicrm-core/pull/19364))** +- **REF Ensure that when doing RLIKE BINARY the field is cast as BINARY t… + ([19399](https://github.com/civicrm/civicrm-core/pull/19399))** -- **(NFC) Regenerate civicrm_generated.mysql ([19363](https://github.com/civicrm/civicrm-core/pull/19363))** +- **[REF] Remove function that is the same as parent + ([19369](https://github.com/civicrm/civicrm-core/pull/19369))** -- **Update permissions for "CiviCRM Admin Menu -> Mailings -> Message Templates" nav item ([19342](https://github.com/civicrm/civicrm-core/pull/19342))** +- **[REF] Standardise methods of determining isTest + ([19417](https://github.com/civicrm/civicrm-core/pull/19417))** -- **Set contribution_page_id from template contribution ([19362](https://github.com/civicrm/civicrm-core/pull/19362))** +- **REF Update CiviCRM default PEAR Error handling to be exception rather… + ([19323](https://github.com/civicrm/civicrm-core/pull/19323))** -- **REF Update CiviCRM default PEAR Error handling to be exception rather… ([19323](https://github.com/civicrm/civicrm-core/pull/19323))** +- **[REF] Extract logical functions from sendTemplate + ([19510](https://github.com/civicrm/civicrm-core/pull/19510) and + [19563](https://github.com/civicrm/civicrm-core/pull/19563))** -- **dev/core#2241 - Deprecate direct calls to isDevelopment() ([19361](https://github.com/civicrm/civicrm-core/pull/19361))** +- **[REF] Move sendNotification out of recur, remove unused related_contact + ([19443](https://github.com/civicrm/civicrm-core/pull/19443))** -- **When two contacts, Contact A and Contact B have the same email address, if Contact A is deleted then Contact B is incorrectly excluded from mailings, does not receive emails ([19360](https://github.com/civicrm/civicrm-core/pull/19360))** +- **[REF] Remove invalid attempt to load contriution id from invoiceID + ([19511](https://github.com/civicrm/civicrm-core/pull/19511))** -- **Dashboard: Improve status messages when moving/deleting dashlets ([19358](https://github.com/civicrm/civicrm-core/pull/19358))** +- **[REF] Stop passing contributionPageID to isEmailReceipt + ([19498](https://github.com/civicrm/civicrm-core/pull/19498))** -- **allow filtering by empty event end, registration start, registration … ([634](https://github.com/civicrm/civicrm-drupal/pull/634))** +- **[NFC] Fix PHP 7.4 Syntax issue in Afform HTML Extension + ([19477](https://github.com/civicrm/civicrm-core/pull/19477))** -- **Fixes issue where adding/removing a contact from CiviCRM Group works … ([580](https://github.com/civicrm/civicrm-drupal/pull/580))** +- **[NFC] Update composer.lock + ([19485](https://github.com/civicrm/civicrm-core/pull/19485))** -- **fix deceased date format ([607](https://github.com/civicrm/civicrm-drupal/pull/607))** +- **[NFC] Whitespace fix up + ([19408](https://github.com/civicrm/civicrm-core/pull/19408))** -- **Advice in failure message is out of date ([633](https://github.com/civicrm/civicrm-drupal/pull/633))** +- **[NFC] Preliminary cleanup + ([19401](https://github.com/civicrm/civicrm-core/pull/19401))** -- **[NFC] - Remove literally empty if block ([632](https://github.com/civicrm/civicrm-drupal/pull/632))** +- **NFC Minor code cleanup to contribution pages + ([19468](https://github.com/civicrm/civicrm-core/pull/19468))** -- **dev/core#2204 Update minimum php install to be 7.2 ([637](https://github.com/civicrm/civicrm-drupal/pull/637))** +- **[NFC] minor code cleanups + ([19366](https://github.com/civicrm/civicrm-core/pull/19366))** -- **dev/core#2204 Make minimum PHP required for install to be 7.2 ([238](https://github.com/civicrm/civicrm-wordpress/pull/238))** +- **[NFC] Update contributor-key.yml with Ahed + ([19378](https://github.com/civicrm/civicrm-core/pull/19378))** -- **dev/core#2204 Update minimum php install to be 7.2 ([126](https://github.com/civicrm/civicrm-backdrop/pull/126))** +- **[NFC] Minor code cleanup + ([19367](https://github.com/civicrm/civicrm-core/pull/19367))** -## Miscellany +- **[NFC] Move Upgrade for navgation from 5.34.alpha1 to 5.35.alpha1 as t… + ([19364](https://github.com/civicrm/civicrm-core/pull/19364))** + +- **(NFC) Regenerate civicrm_generated.mysql + ([19363](https://github.com/civicrm/civicrm-core/pull/19363))** + +- **[NFC] - Remove literally empty if block + ([632](https://github.com/civicrm/civicrm-drupal/pull/632))** + +- **[NFC] Update Schema Handler to use the standard create table syntax of using + `ROW_FORMAT=dynamic` + ([19705](https://github.com/civicrm/civicrm-core/pull/19705))** ## Credits This release was developed by the following code authors: -AGH Strategies - Alice Frumin, Andrew Hunt; Agileware - Justin Freeman; Christian Wach; CiviCoop - Jaap Jansma, Klaas Eikelboom; CiviCRM - Coleman Watts, Tim Otten; CiviDesk - Yashodha Chaku; CompuCorp - Ahed Eid; Coop SymbioTIC - Mathieu Lutfy; Dave D; dependabot[bot]; ECOPLAN - Torben Bertram; Freeform Solutions - Herb van den Dool; iXiam - Vangelis Pantazis; JMA Consulting - Seamus Lee; John Kingsnorth; Megaphone Technology Consulting - Jon Goldberg; MJW Consulting - Matthew Wire; Skvare - Sunil Pawar; Stephen Palmstrom; Wikimedia Foundation - Eileen McNaughton +AGH Strategies - Alice Frumin, Andie Hunt; Agileware - Justin Freeman; +Christian Wach; CiviCoop - Jaap Jansma, Klaas Eikelboom; CiviCRM - Coleman +Watts, Tim Otten; CiviDesk - Yashodha Chaku; CompuCorp - Ahed Eid; Coop +SymbioTIC - Mathieu Lutfy; Dave D; ECOPLAN - Torben Bertram; Freeform +Solutions - Herb van den Dool; iXiam - Vangelis Pantazis; JMA Consulting - +Seamus Lee; John Kingsnorth; Megaphone Technology Consulting - Jon Goldberg; MJW +Consulting - Matthew Wire; Skvare - Sunil Pawar; Stephen Palmstrom; Wikimedia +Foundation - Eileen McNaughton Most authors also reviewed code for this release; in addition, the following reviewers contributed their comments: -AGH Strategies - Alice Frumin; Agileware - Justin Freeman; Artful Robot - Rich Lott; Blackfly Solutions - Alan Dixon; civibot[bot]; CiviCoop - Jaap Jansma; civicrm-builder; CiviCRM - Coleman Watts, Tim Otten; CiviDesk - Yashodha Chaku; Coop SymbioTIC - Mathieu Lutfy; Dave D; ECOPLAN - Torben Bertram; Freeform Solutions - Herb van den Dool; Fuzion - Jitendra Purohit; JMA Consulting - Monish Deb, Seamus Lee; John Kingsnorth; MJCO - Mikey O'Toole; MJW Consulting - Matthew Wire; StijnVanhandsaeme; Tadpole Collective - Kevin Cristiano; Wikimedia Foundation - Eileen McNaughton +Agileware - Justin Freeman; Artful Robot - Rich Lott; Blackfly Solutions - Alan +Dixon; Fuzion - Jitendra Purohit; JMA Consulting - Monish Deb; MJCO - Mikey +O'Toole; StijnVanhandsaeme; Tadpole Collective - Kevin Cristiano ## Feedback -These release notes are edited by Alice Frumin and Andrew Hunt. If you'd like +These release notes are edited by Alice Frumin and Andie Hunt. If you'd like to provide feedback on them, please log in to https://chat.civicrm.org/civicrm and contact `@agh1`.