X-Git-Url: https://vcs.fsf.org/?a=blobdiff_plain;f=functions%2Fdb_prefs.php;h=a973f363987285afc38a3eeaa37294f870664ddf;hb=ba0d44609ab8bc4e5ec05d0846dfa055705ee039;hp=a8790b9057829fc03281d08c654c83b0dddca442;hpb=b4bf2ec14850365e3212d2a2f02936b050c15c10;p=squirrelmail.git diff --git a/functions/db_prefs.php b/functions/db_prefs.php index a8790b90..a973f363 100644 --- a/functions/db_prefs.php +++ b/functions/db_prefs.php @@ -3,16 +3,12 @@ /* * db_prefs.php * - * Copyright (c) 1999-2002 The SquirrelMail Project Team + * Copyright (c) 1999-2003 The SquirrelMail Project Team * Licensed under the GNU GPL. For full terms see the file COPYING. * * This contains functions for manipulating user preferences * stored in a database, accessed though the Pear DB layer. * - * To use this instead of the regular prefs.php, create a - * database as described below, and replace prefs.php - * with this file. - * * Database: * --------- * @@ -36,8 +32,8 @@ define('SMDB_UNKNOWN', 0); define('SMDB_MYSQL', 1); define('SMDB_PGSQL', 2); -include_once('DB.php'); -require_once('../config/config.php'); +require_once('DB.php'); +require_once(SM_PATH . 'config/config.php'); global $prefs_are_cached, $prefs_cache; @@ -48,8 +44,8 @@ function cachePrefValues($username) { return; } - session_unregister('prefs_cache'); - session_unregister('prefs_are_cached'); + sqsession_unregister('prefs_cache'); + sqsession_unregister('prefs_are_cached'); $db = new dbPrefs; if(isset($db->error)) { @@ -67,8 +63,8 @@ function cachePrefValues($username) { $prefs_are_cached = true; - session_register('prefs_cache'); - session_register('prefs_are_cached'); + sqsession_register($prefs_cache, 'prefs_cache'); + sqsession_register($prefs_are_cached, 'prefs_are_cached'); } class dbPrefs { @@ -81,7 +77,7 @@ class dbPrefs { var $error = NULL; var $db_type = SMDB_UNKNOWN; - var $default = Array('chosen_theme' => '../themes/default_theme.php', + var $default = Array('theme_default' => 0, 'show_html_default' => '0'); function open() { @@ -112,7 +108,7 @@ class dbPrefs { } $dbh = DB::connect($prefs_dsn, true); - if(DB::isError($dbh) || DB::isWarning($dbh)) { + if(DB::isError($dbh)) { $this->error = DB::errorMessage($dbh); return false; } @@ -169,10 +165,6 @@ class dbPrefs { unset($prefs_cache[$key]); - if(substr($key, 0, 9) == 'highlight') { - $this->renumberHighlightList($user); - } - return true; } @@ -275,65 +267,6 @@ class dbPrefs { } } - /* - * When a highlight option is deleted the preferences module - * must renumber the list. This should be done somewhere else, - * but it is not, so.... - */ - function renumberHighlightList($user) { - if (!$this->open()) { - return; - } - $query = sprintf("SELECT %s, %s as prefkey, %s as prefval FROM %s WHERE %s='%s' ". - "AND %s LIKE 'highlight%%' ORDER BY %s", - $this->user_field, - $this->key_field, - $this->val_field, - $this->table, - $this->user_field, - $this->dbh->quoteString($user), - $this->key_field, - $this->key_field); - - $res = $this->dbh->query($query); - if(DB::isError($res)) { - $this->failQuery($res); - } - - /* Store old data in array */ - $rows = Array(); - while($row = $res->fetchRow(DB_FETCHMODE_ASSOC)) { - $rows[] = $row; - } - - /* Renumber keys of old data */ - $hilinum = 0; - for($i = 0; $i < count($rows) ; $i++) { - $oldkey = $rows[$i]['prefkey']; - $newkey = substr($oldkey, 0, 9) . $hilinum; - $hilinum++; - - if($oldkey != $newkey) { - $query = sprintf("UPDATE %s SET %s='%s' ". - "WHERE %s ='%s' AND %s='%s'", - $this->table, - $this->key_field, - $this->dbh->quoteString($newkey), - $this->user_field, - $this->dbh->quoteString($user), - $this->key_field, - $this->dbh->quoteString($oldkey)); - - $res = $this->dbh->simpleQuery($query); - if(DB::isError($res)) { - $this->failQuery($res); - } - } - } - - return; - } - } /* end class dbPrefs */ @@ -351,12 +284,19 @@ function getPref($data_dir, $username, $string, $default = '') { /* Remove the pref $string */ function removePref($data_dir, $username, $string) { + global $prefs_cache; $db = new dbPrefs; if(isset($db->error)) { $db->failQuery(); } $db->deleteKey($username, $string); + + if (isset($prefs_cache[$string])) { + unset($prefs_cache[$string]); + } + + sqsession_register($prefs_cache , 'prefs_cache'); return; } @@ -368,7 +308,7 @@ function setPref($data_dir, $username, $string, $set_to) { return; } - if ($set_to == '') { + if ($set_to === '') { removePref($data_dir, $username, $string); return; } @@ -383,7 +323,7 @@ function setPref($data_dir, $username, $string, $set_to) { assert_options(ASSERT_ACTIVE, 1); assert_options(ASSERT_BAIL, 1); assert ('$set_to == $prefs_cache[$string]'); - + sqsession_register($prefs_cache , 'prefs_cache'); return; } @@ -397,33 +337,23 @@ function checkForPrefs($data_dir, $username) { /* Writes the Signature */ function setSig($data_dir, $username, $number, $string) { - $db = new dbPrefs; - if(isset($db->error)) { - $db->failQuery(); - } - if ($number == "g") { $key = '___signature___'; } else { $key = sprintf('___sig%s___', $number); } - $db->setKey($username, $key, $string); + setPref($data_dir, $username, $key, $string); return; } /* Gets the signature */ function getSig($data_dir, $username, $number) { - $db = new dbPrefs; - if(isset($db->error)) { - $db->failQuery(); - } - if ($number == "g") { $key = '___signature___'; } else { $key = sprintf('___sig%d___', $number); } - return $db->getKey($username, $key); + return getPref($data_dir, $username, $key); } ?>