X-Git-Url: https://vcs.fsf.org/?a=blobdiff_plain;f=api%2Fv3%2FGeneric%2FSetvalue.php;h=b6ce00c9bc2b3341f70c4d7e7b9017e79ed2a478;hb=a30c801bdf595f8a00898941142b57773e097244;hp=d6aecd798ecef61c968a1b2f44b71dc0b8ab01b1;hpb=b18e2d7c83a0957e6fbcfc0d0d478cdfb45ae5e5;p=civicrm-core.git diff --git a/api/v3/Generic/Setvalue.php b/api/v3/Generic/Setvalue.php index d6aecd798e..b6ce00c9bc 100644 --- a/api/v3/Generic/Setvalue.php +++ b/api/v3/Generic/Setvalue.php @@ -1,27 +1,11 @@ 'NaN', 'field' => "id", - )); + ]); } $field = CRM_Utils_String::munge($params['field']); $value = $params['value']; - $fields = civicrm_api($entity, 'getFields', array( + $fields = civicrm_api($entity, 'getFields', [ 'version' => 3, 'action' => 'create', - "sequential") - ); + ]); // getfields error, shouldn't happen. if ($fields['is_error']) { return $fields; @@ -69,7 +52,7 @@ function civicrm_api3_generic_setValue($apiRequest) { // Trim off the id portion of a multivalued custom field name $fieldKey = $isCustom && substr_count($field, '_') > 1 ? rtrim(rtrim($field, '1234567890'), '_') : $field; if (!array_key_exists($fieldKey, $fields)) { - return civicrm_api3_create_error("Param 'field' ($field) is invalid. must be an existing field", array("error_code" => "invalid_field", "fields" => array_keys($fields))); + return civicrm_api3_create_error("Param 'field' ($field) is invalid. must be an existing field", ["error_code" => "invalid_field", "fields" => array_keys($fields)]); } $def = $fields[$fieldKey]; @@ -78,27 +61,27 @@ function civicrm_api3_generic_setValue($apiRequest) { // TODO: create a utility for this since it's needed in many places if (!empty($def['required']) || !empty($def['is_required'])) { if ((empty($value) || $value === 'null') && $value !== '0' && $value !== 0) { - return civicrm_api3_create_error(ts('%1 is a required field.', array(1 => $title)), array("error_code" => "required", "field" => $field)); + return civicrm_api3_create_error(ts('%1 is a required field.', [1 => $title]), ["error_code" => "required", "field" => $field]); } } switch ($def['type']) { case CRM_Utils_Type::T_FLOAT: if (!is_numeric($value) && !empty($value) && $value !== 'null') { - return civicrm_api3_create_error(ts('%1 must be a number.', array(1 => $title)), array('error_code' => 'NaN')); + return civicrm_api3_create_error(ts('%1 must be a number.', [1 => $title]), ['error_code' => 'NaN']); } break; case CRM_Utils_Type::T_INT: if (!CRM_Utils_Rule::integer($value) && !empty($value) && $value !== 'null') { - return civicrm_api3_create_error(ts('%1 must be a number.', array(1 => $title)), array('error_code' => 'NaN')); + return civicrm_api3_create_error(ts('%1 must be a number.', [1 => $title]), ['error_code' => 'NaN']); } break; case CRM_Utils_Type::T_STRING: case CRM_Utils_Type::T_TEXT: if (!CRM_Utils_Rule::xssString($value)) { - return civicrm_api3_create_error(ts('Illegal characters in input (potential scripting attack)'), array('error_code' => 'XSS')); + return civicrm_api3_create_error(ts('Illegal characters in input (potential scripting attack)'), ['error_code' => 'XSS']); } if (array_key_exists('maxlength', $def)) { $value = substr($value, 0, $def['maxlength']); @@ -123,11 +106,11 @@ function civicrm_api3_generic_setValue($apiRequest) { break; default: - return civicrm_api3_create_error("Param '$field' is of a type not managed yet (" . $def['type'] . "). Join the API team and help us implement it", array('error_code' => 'NOT_IMPLEMENTED')); + return civicrm_api3_create_error("Param '$field' is of a type not managed yet (" . $def['type'] . "). Join the API team and help us implement it", ['error_code' => 'NOT_IMPLEMENTED']); } $dao_name = _civicrm_api3_get_DAO($entity); - $params = array('id' => $id, $field => $value); + $params = ['id' => $id, $field => $value]; if ((!empty($def['pseudoconstant']) || !empty($def['option_group_id'])) && $value !== '' && $value !== 'null') { _civicrm_api3_api_match_pseudoconstant($params[$field], $entity, $field, $def);