X-Git-Url: https://vcs.fsf.org/?a=blobdiff_plain;f=CRM%2FCore%2FPayment%2FPayPalImpl.php;h=df23d778746cc6b235b09012d2da961dbe07e519;hb=3f0a734f36698ef04066b1c2c3778838650b05ca;hp=8c556973ad8dee45e837dc8fc93a9b2ac7647930;hpb=096b1764da9d4ba2b16186f3311e57f0decca89c;p=civicrm-core.git diff --git a/CRM/Core/Payment/PayPalImpl.php b/CRM/Core/Payment/PayPalImpl.php index 8c556973ad..df23d77874 100644 --- a/CRM/Core/Payment/PayPalImpl.php +++ b/CRM/Core/Payment/PayPalImpl.php @@ -1,27 +1,11 @@ getContributionID(); "&b={$params['contributionID']}" . "&p={$params['contributionPageID']}"; @@ -570,7 +553,6 @@ class CRM_Core_Payment_PayPalImpl extends CRM_Core_Payment { $args['PROFILEREFERENCE'] = "" . "i=" . $params['invoiceID'] . "&m=" . $component . "&c=" . $params['contactID'] . "&r=" . $params['contributionRecurID'] . - // @todo use $this->getContributionID(); "&b=" . $params['contributionID'] . "&p=" . $params['contributionPageID']; } @@ -882,7 +864,6 @@ class CRM_Core_Payment_PayPalImpl extends CRM_Core_Payment { $notifyParameters = ['module' => $component]; $notifyParameterMap = [ 'contactID' => 'contactID', - // @todo use $this->getContributionID(); 'contributionID' => 'contributionID', 'eventID' => 'eventID', 'participantID' => 'participantID', @@ -906,7 +887,6 @@ class CRM_Core_Payment_PayPalImpl extends CRM_Core_Payment { $cancelUrlString = "$cancel=1&cancel=1&qfKey={$params['qfKey']}"; if (!empty($params['is_recur'])) { - // @todo use $this->getContributionID(); $cancelUrlString .= "&isRecur=1&recurId={$params['contributionRecurID']}&contribId={$params['contributionID']}"; } @@ -1096,12 +1076,6 @@ class CRM_Core_Payment_PayPalImpl extends CRM_Core_Payment { if ($outcome != 'success' && $outcome != 'successwithwarning') { throw new PaymentProcessorException("{$result['l_shortmessage0']} {$result['l_longmessage0']}"); - $e = CRM_Core_Error::singleton(); - $e->push($result['l_errorcode0'], - 0, NULL, - "{$result['l_shortmessage0']} {$result['l_longmessage0']}" - ); - return $e; } return $result;