X-Git-Url: https://vcs.fsf.org/?a=blobdiff_plain;f=CRM%2FContact%2FForm%2FTask.php;h=1d1228e9f12bf5ab10a6fa431399ebb8b6511d76;hb=709e574bfc8b047d9e9f9a6ad84595bc3f560b54;hp=b783d0230d8acdf807110d123cc8f7e84d33d13e;hpb=e913987d303f2c51e60be23820fc8d1031e7eadd;p=civicrm-core.git diff --git a/CRM/Contact/Form/Task.php b/CRM/Contact/Form/Task.php index b783d0230d..1d1228e9f1 100644 --- a/CRM/Contact/Form/Task.php +++ b/CRM/Contact/Form/Task.php @@ -1,7 +1,7 @@ _contactIds = array(); $form->_contactTypes = array(); @@ -259,7 +254,6 @@ class CRM_Contact_Form_Task extends CRM_Core_Form { } } - if (CRM_Utils_Array::value('radio_ts', self::$_searchFormValues) == 'ts_sel' && ($form->_action != CRM_Core_Action::COPY) ) { @@ -278,8 +272,9 @@ class CRM_Contact_Form_Task extends CRM_Core_Form { } /** - * Function to get the contact id for custom search - * we are not using prev/next table incase of custom search + * Get the contact id for custom search. + * + * we are not using prev/next table in case of custom search */ public function getContactIds() { // need to perform action on all contacts @@ -292,7 +287,7 @@ class CRM_Contact_Form_Task extends CRM_Core_Form { } $selectorName = $this->controller->selectorName(); - require_once(str_replace('_', DIRECTORY_SEPARATOR, $selectorName) . '.php'); + require_once str_replace('_', DIRECTORY_SEPARATOR, $selectorName) . '.php'; $fv = $this->get('formValues'); $customClass = $this->get('customSearchClass'); @@ -327,64 +322,49 @@ class CRM_Contact_Form_Task extends CRM_Core_Form { /** - * This function sets the default values for the form. Relationship that in edit/view action - * the default values are retrieved from the database + * Set default values for the form. Relationship that in edit/view action. * - * @access public + * The default values are retrieved from the database. * * @return array */ - function setDefaultValues() { + public function setDefaultValues() { $defaults = array(); return $defaults; } /** - * This function is used to add the rules for form. - * - * @return void - * @access public + * Add the rules for form. */ - function addRules() { + public function addRules() { } /** - * Function to actually build the form - * - * @return void - * @access public + * Build the form object. */ public function buildQuickForm() { $this->addDefaultButtons(ts('Confirm Action')); } /** - * process the form after the input has been submitted and validated - * - * @access public - * - * @return void + * Process the form after the input has been submitted and validated. */ public function postProcess() { } - //end of function - /** - * simple shell that derived classes can call to add buttons to - * the form with a customized title for the main Submit + * Simple shell that derived classes can call to add form buttons. + * + * Allows customized title for the main Submit * - * @param string $title title of the main button + * @param string $title + * Title of the main button. * @param string $nextType + * Button type for the form after processing. * @param string $backType * @param bool $submitOnce - * - * @internal param string $type button type for the form after processing - * - * @return void - * @access public */ - function addDefaultButtons($title, $nextType = 'next', $backType = 'back', $submitOnce = FALSE) { + public function addDefaultButtons($title, $nextType = 'next', $backType = 'back', $submitOnce = FALSE) { $this->addButtons(array( array( 'type' => $nextType, @@ -400,12 +380,9 @@ class CRM_Contact_Form_Task extends CRM_Core_Form { } /** - * replace ids of household members in $this->_contactIds with the id of their household. - * CRM-8338 - * - * @access public + * Replace ids of household members in $this->_contactIds with the id of their household. * - * @return void + * CRM-8338 */ public function mergeContactIdsByHousehold() { if (empty($this->_contactIds)) { @@ -443,15 +420,15 @@ class CRM_Contact_Form_Task extends CRM_Core_Form { } // Find related households. - $relationSelect = "SELECT contact_household.id as household_id, {$contactA} as refContact "; + $relationSelect = "SELECT contact_household.id as household_id, {$contactA} as refContact "; $relationFrom = " FROM civicrm_contact contact_household INNER JOIN civicrm_relationship crel ON crel.{$contactB} = contact_household.id AND crel.relationship_type_id = {$id} "; // Check for active relationship status only. - $today = date('Ymd'); - $relationActive = " AND (crel.is_active = 1 AND ( crel.end_date is NULL OR crel.end_date >= {$today} ) )"; - $relationWhere = " WHERE contact_household.is_deleted = 0 AND crel.{$contactA} IN ( {$relID} ) {$relationActive}"; - $relationGroupBy = " GROUP BY crel.{$contactA}"; + $today = date('Ymd'); + $relationActive = " AND (crel.is_active = 1 AND ( crel.end_date is NULL OR crel.end_date >= {$today} ) )"; + $relationWhere = " WHERE contact_household.is_deleted = 0 AND crel.{$contactA} IN ( {$relID} ) {$relationActive}"; + $relationGroupBy = " GROUP BY crel.{$contactA}"; $relationQueryString = "$relationSelect $relationFrom $relationWhere $relationGroupBy"; $householdsDAO = CRM_Core_DAO::executeQuery($relationQueryString); @@ -467,5 +444,5 @@ class CRM_Contact_Form_Task extends CRM_Core_Form { $householdsDAO->free(); } } -} +}