Merge pull request #16469 from civicrm/5.22

[civicrm-core.git] / tests / phpunit / api / v3 / SyntaxConformanceTest.php

diff --git a/tests/phpunit/api/v3/SyntaxConformanceTest.php b/tests/phpunit/api/v3/SyntaxConformanceTest.php
index dbcd8fd6f0a9bbb1e11a773bff0143bb068eb96a..30c4e9e51b046bcac1e12c8b1396634fa32561b1 100644 (file)
--- a/tests/phpunit/api/v3/SyntaxConformanceTest.php
+++ b/tests/phpunit/api/v3/SyntaxConformanceTest.php
@@ -1,27 +1,11 @@
 <?php
 /*
  +--------------------------------------------------------------------+
- | CiviCRM version 5                                                  |
- +--------------------------------------------------------------------+
- | Copyright CiviCRM LLC (c) 2004-2020                                |
- +--------------------------------------------------------------------+
- | This file is a part of CiviCRM.                                    |
- |                                                                    |
- | CiviCRM is free software; you can copy, modify, and distribute it  |
- | under the terms of the GNU Affero General Public License           |
- | Version 3, 19 November 2007 and the CiviCRM Licensing Exception.   |
- |                                                                    |
- | CiviCRM is distributed in the hope that it will be useful, but     |
- | WITHOUT ANY WARRANTY; without even the implied warranty of         |
- | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.               |
- | See the GNU Affero General Public License for more details.        |
+ | Copyright CiviCRM LLC. All rights reserved.                        |
  |                                                                    |
- | You should have received a copy of the GNU Affero General Public   |
- | License and the CiviCRM Licensing Exception along                  |
- | with this program; if not, contact CiviCRM LLC                     |
- | at info[AT]civicrm[DOT]org. If you have questions about the        |
- | GNU Affero General Public License or the licensing of CiviCRM,     |
- | see the CiviCRM license FAQ at http://civicrm.org/licensing        |
+ | This work is published under the GNU AGPLv3 license with some      |
+ | permitted exceptions and without any warranty. For full license    |
+ | and copyright information, see https://civicrm.org/licensing       |
  +--------------------------------------------------------------------+
  */
 
@@ -41,7 +25,8 @@ class api_v3_SyntaxConformanceTest extends CiviUnitTestCase {
   protected $_apiversion = 3;
 
   /**
-   * @var array e.g. $this->deletes['CRM_Contact_DAO_Contact'][] = $contactID;
+   * @var array
+   * e.g. $this->deletes['CRM_Contact_DAO_Contact'][] = $contactID;
    */
   protected $deletableTestObjects;
 
@@ -663,6 +648,12 @@ class api_v3_SyntaxConformanceTest extends CiviUnitTestCase {
           'is_primary',
         ],
       ],
+      'FinancialTrxn' => [
+        'cant_update' => [
+          // Altering fee amount will also cause net_amount to be recalculated.
+          'fee_amount',
+        ],
+      ],
       'Navigation' => [
         'cant_update' => [
           // Weight is deliberately altered when this is changed - skip.
@@ -825,21 +816,6 @@ class api_v3_SyntaxConformanceTest extends CiviUnitTestCase {
     $this->assertContains("Unknown api version", $result['error_message']);
   }
 
-  /**
-   * @dataProvider entities_get
-   * @param $Entity
-   */
-  public function testEmptyParam_getString($Entity) {
-
-    if (in_array($Entity, $this->toBeImplemented['get'])) {
-      // $this->markTestIncomplete("civicrm_api3_{$Entity}_get to be implemented");
-      return;
-    }
-    $result = $this->callAPIFailure($Entity, 'Get', 'string');
-    $this->assertEquals(2000, $result['error_code']);
-    $this->assertEquals('Input variable `params` is not an array', $result['error_message']);
-  }
-
   /**
    * @dataProvider entities_get
    * @Xdepends testEmptyParam_get // no need to test the simple if the empty doesn't work/is skipped. doesn't seem to work
@@ -1333,15 +1309,6 @@ class api_v3_SyntaxConformanceTest extends CiviUnitTestCase {
     $result = $this->callAPIFailure($Entity, 'Create', ['id' => 999]);
   }
 
-  /**
-   * @dataProvider entities
-   */
-  public function testCreateWrongTypeParamTag_create() {
-    $result = civicrm_api("Tag", 'Create', 'this is not a string');
-    $this->assertEquals(1, $result['is_error']);
-    $this->assertEquals("Input variable `params` is not an array", $result['error_message']);
-  }
-
   /**
    * @dataProvider entities_updatesingle
    *
@@ -1607,15 +1574,6 @@ class api_v3_SyntaxConformanceTest extends CiviUnitTestCase {
     $result = $this->callAPIFailure($Entity, 'Delete', ['id' => 999999]);
   }
 
-  /**
-   * @dataProvider entities
-   */
-  public function testDeleteWrongTypeParamTag_delete() {
-    $result = civicrm_api("Tag", 'Delete', 'this is not a string');
-    $this->assertEquals(1, $result['is_error']);
-    $this->assertEquals("Input variable `params` is not an array", $result['error_message']);
-  }
-
   /**
    * Create two entities and make sure delete action only deletes one!
    *