use api success & api failure & apiSetup for cleaner tests

[civicrm-core.git] / tests / phpunit / api / v3 / NoteTest.php

diff --git a/tests/phpunit/api/v3/NoteTest.php b/tests/phpunit/api/v3/NoteTest.php
index d6903eee87359ab582deeed05591775967f46118..5d451a6f506f8f3091aeca7074a4ae3a0f87e18e 100644 (file)
--- a/tests/phpunit/api/v3/NoteTest.php
+++ b/tests/phpunit/api/v3/NoteTest.php
@@ -90,7 +90,7 @@ class api_v3_NoteTest extends CiviUnitTestCase {
   function testGetWithWrongParamsType() {
     $params = 'a string';
     $result = civicrm_api('note', 'get', $params);
-    $this->assertEquals($result['is_error'], 1,
+    $this->assertAPIFailure($result,
       "In line " . __LINE__
     );
   }
@@ -130,7 +130,7 @@ class api_v3_NoteTest extends CiviUnitTestCase {
     );
     $result = civicrm_api3_note_get($params);
     $this->documentMe($this->_params, $result, __FUNCTION__, __FILE__);
-    $this->assertEquals($result['is_error'], 0, 'in line ' . __LINE__);
+    $this->assertAPISuccess($result, 'in line ' . __LINE__);
   }
 
 
@@ -143,7 +143,7 @@ class api_v3_NoteTest extends CiviUnitTestCase {
   function testCreateWithWrongParamsType() {
     $params = 'a string';
     $result = civicrm_api('note', 'create', $params);
-    $this->assertEquals($result['is_error'], 1,
+    $this->assertAPIFailure($result,
       "In line " . __LINE__
     );
     $this->assertEquals($result['error_message'], 'Input variable `params` is not an array');
@@ -156,7 +156,7 @@ class api_v3_NoteTest extends CiviUnitTestCase {
   function testCreateWithEmptyNoteField() {
     $this->_params['note'] = "";
     $result = civicrm_api('note', 'create', $this->_params);
-    $this->assertEquals($result['is_error'], 1);
+    $this->assertAPIFailure($result);
     $this->assertEquals($result['error_message'], 'Mandatory key(s) missing from params array: note');
   }
 
@@ -167,7 +167,7 @@ class api_v3_NoteTest extends CiviUnitTestCase {
   function testCreateWithoutEntityId() {
     unset($this->_params['entity_id']);
     $result = civicrm_api('note', 'create', $this->_params);
-    $this->assertEquals($result['is_error'], 1);
+    $this->assertAPIFailure($result);
     $this->assertEquals($result['error_message'], 'Mandatory key(s) missing from params array: entity_id');
   }
 
@@ -178,7 +178,7 @@ class api_v3_NoteTest extends CiviUnitTestCase {
   function testCreateWithEmptyEntityId() {
     $this->_params['entity_id'] = "";
     $result = civicrm_api('note', 'create', $this->_params);
-    $this->assertEquals($result['is_error'], 1);
+    $this->assertAPIFailure($result);
     $this->assertEquals($result['error_message'], 'Mandatory key(s) missing from params array: entity_id');
   }
 
@@ -193,7 +193,7 @@ class api_v3_NoteTest extends CiviUnitTestCase {
     $this->assertEquals(date('Y-m-d', strtotime($this->_params['modified_date'])), date('Y-m-d', strtotime($result['values'][$result['id']]['modified_date'])), 'in line ' . __LINE__);
 
     $this->assertArrayHasKey('id', $result, 'in line ' . __LINE__);
-    $this->assertEquals($result['is_error'], 0, 'in line ' . __LINE__);
+    $this->assertAPISuccess($result, 'in line ' . __LINE__);
     $note = array(
       'id' => $result['id'],
       'version' => $this->_apiversion,
@@ -213,7 +213,7 @@ class api_v3_NoteTest extends CiviUnitTestCase {
       'version' => $this->_apiversion,
     );
     $result = civicrm_api('Note', 'Create', $params);
-    $this->assertEquals($result['is_error'], 0, 'in line ' . __LINE__);
+    $this->assertAPISuccess($result, 'in line ' . __LINE__);
     $this->assertEquals($result['values'][0]['note'], "Hello!!! ' testing Note", 'in line ' . __LINE__);
     $this->assertEquals($result['values'][0]['subject'], "With a '", 'in line ' . __LINE__);
     $this->assertArrayHasKey('id', $result, 'in line ' . __LINE__);
@@ -250,7 +250,7 @@ class api_v3_NoteTest extends CiviUnitTestCase {
   function testUpdateWithWrongParamsType() {
     $params = 'a string';
     $result = civicrm_api('note', 'create', $params);
-    $this->assertEquals($result['is_error'], 1,
+    $this->assertAPIFailure($result,
       "In line " . __LINE__
     );
   }
@@ -312,7 +312,7 @@ class api_v3_NoteTest extends CiviUnitTestCase {
   function testDeleteWithWrongParamsType() {
     $params = 'a string';
     $result = civicrm_api('note', 'delete', $params);
-    $this->assertEquals($result['is_error'], 1,
+    $this->assertAPIFailure($result,
       "In line " . __LINE__
     );
   }
@@ -356,7 +356,7 @@ class api_v3_NoteTest extends CiviUnitTestCase {
     $result = civicrm_api('note', 'delete', $params);
 
     $this->documentMe($params, $result, __FUNCTION__, __FILE__);
-    $this->assertEquals($result['is_error'], 0, 'in line ' . __LINE__);
+    $this->assertAPISuccess($result, 'in line ' . __LINE__);
   }
 }