Merge pull request #16469 from civicrm/5.22

[civicrm-core.git] / tests / phpunit / api / v3 / ActivityCaseTest.php

diff --git a/tests/phpunit/api/v3/ActivityCaseTest.php b/tests/phpunit/api/v3/ActivityCaseTest.php
index b2de06cdd8c096e85ad9f844fba55ff6fccb2de0..4bba2e4a811f0dd91270c7d36f4776898dac24b6 100644 (file)
--- a/tests/phpunit/api/v3/ActivityCaseTest.php
+++ b/tests/phpunit/api/v3/ActivityCaseTest.php
@@ -36,17 +36,17 @@ class api_v3_ActivityCaseTest extends CiviCaseTestCase {
 
     $this->_cid = $this->individualCreate();
 
-    $this->_case = $this->callAPISuccess('case', 'create', array(
+    $this->_case = $this->callAPISuccess('case', 'create', [
       'case_type_id' => $this->caseTypeId,
       'subject' => __CLASS__,
       'contact_id' => $this->_cid,
-    ));
+    ]);
 
-    $this->_otherActivity = $this->callAPISuccess('Activity', 'create', array(
+    $this->_otherActivity = $this->callAPISuccess('Activity', 'create', [
       'source_contact_id' => $this->_cid,
       'activity_type_id' => 'Phone Call',
       'subject' => 'Ask not what your API can do for you, but what you can do for your API.',
-    ));
+    ]);
   }
 
   /**
@@ -55,17 +55,17 @@ class api_v3_ActivityCaseTest extends CiviCaseTestCase {
    */
   public function testActivityCreateOnCase() {
     $hash = substr(sha1(CIVICRM_SITE_KEY . $this->_case['id']), 0, 7);
-    $subjectArr = array(
+    $subjectArr = [
       "[case #{$this->_case['id']}] test activity recording under case with id",
       "[case #{$hash}] test activity recording under case with id",
-    );
+    ];
     foreach ($subjectArr as $subject) {
-      $activity = $this->callAPISuccess('Activity', 'create', array(
+      $activity = $this->callAPISuccess('Activity', 'create', [
         'source_contact_id' => $this->_cid,
         'activity_type_id' => 'Phone Call',
         'subject' => $subject,
-      ));
-      $case = $this->callAPISuccessGetSingle('Activity', array('return' => array("case_id"), 'id' => $activity['id']));
+      ]);
+      $case = $this->callAPISuccessGetSingle('Activity', ['return' => ["case_id"], 'id' => $activity['id']]);
       //Check if case id is present for the activity.
       $this->assertEquals($this->_case['id'], $case['case_id'][0]);
     }
@@ -75,36 +75,36 @@ class api_v3_ActivityCaseTest extends CiviCaseTestCase {
     $this->assertTrue(is_numeric($this->_case['id']));
     $this->assertTrue(is_numeric($this->_otherActivity['id']));
 
-    $getByCaseId = $this->callAPIAndDocument('Activity', 'get', array(
+    $getByCaseId = $this->callAPIAndDocument('Activity', 'get', [
       'case_id' => $this->_case['id'],
-    ), __FUNCTION__, __FILE__);
+    ], __FUNCTION__, __FILE__);
     $this->assertNotEmpty($getByCaseId['values']);
     $getByCaseId_ids = array_keys($getByCaseId['values']);
 
-    $getByCaseNotNull = $this->callAPIAndDocument('Activity', 'get', array(
-      'case_id' => array('IS NOT NULL' => 1),
-    ), __FUNCTION__, __FILE__);
+    $getByCaseNotNull = $this->callAPIAndDocument('Activity', 'get', [
+      'case_id' => ['IS NOT NULL' => 1],
+    ], __FUNCTION__, __FILE__);
     $this->assertNotEmpty($getByCaseNotNull['values']);
     $getByCaseNotNull_ids = array_keys($getByCaseNotNull['values']);
 
-    $getByCaseNull = $this->callAPIAndDocument('Activity', 'get', array(
-      'case_id' => array('IS NULL' => 1),
-    ), __FUNCTION__, __FILE__);
+    $getByCaseNull = $this->callAPIAndDocument('Activity', 'get', [
+      'case_id' => ['IS NULL' => 1],
+    ], __FUNCTION__, __FILE__);
     $this->assertNotEmpty($getByCaseNull['values']);
     $getByCaseNull_ids = array_keys($getByCaseNull['values']);
 
     $this->assertTrue(in_array($this->_otherActivity['id'], $getByCaseNull_ids));
     $this->assertNotTrue(in_array($this->_otherActivity['id'], $getByCaseId_ids));
     $this->assertEquals($getByCaseId_ids, $getByCaseNotNull_ids);
-    $this->assertEquals(array(), array_intersect($getByCaseId_ids, $getByCaseNull_ids));
+    $this->assertEquals([], array_intersect($getByCaseId_ids, $getByCaseNull_ids));
   }
 
   public function testActivityGetWithCaseInfo() {
-    $activities = $this->callAPISuccess('Activity', 'get', array(
+    $activities = $this->callAPISuccess('Activity', 'get', [
       'sequential' => 1,
       'case_id' => $this->_case['id'],
-      'return' => array('case_id', 'case_id.subject'),
-    ));
+      'return' => ['case_id', 'case_id.subject'],
+    ]);
     $this->assertEquals(__CLASS__, $activities['values'][0]['case_id.subject']);
     // Note - case_id is always an array
     $this->assertEquals($this->_case['id'], $activities['values'][0]['case_id'][0]);