Fix some uses of sleep, comment the rest

[civicrm-core.git] / tests / phpunit / WebTest / Export / ExportCiviSeleniumTestCase.php

diff --git a/tests/phpunit/WebTest/Export/ExportCiviSeleniumTestCase.php b/tests/phpunit/WebTest/Export/ExportCiviSeleniumTestCase.php
index c739bc57ffb711cc39dcc113f62985d38f18410c..a9bc270cf22e21ea1efd5dcb7bc7f4221e97aea9 100644 (file)
--- a/tests/phpunit/WebTest/Export/ExportCiviSeleniumTestCase.php
+++ b/tests/phpunit/WebTest/Export/ExportCiviSeleniumTestCase.php
@@ -49,6 +49,10 @@ class ExportCiviSeleniumTestCase extends CiviSeleniumTestCase {
     // Download file.
     // File will automatically download without confirmation.
     $this->click($selector);
+    // Because it tends to cause problems, all uses of sleep() must be justified in comments
+    // Sleep should never be used for wait for anything to load from the server
+    // FIXME: consider doing the following assertion in a while loop
+    // with a more reasonable sleep time of 2 seconds per loop iteration
     sleep(20);
 
     // File was downloaded?