INFRA-132 - tests/ - PHPStorm cleanup

[civicrm-core.git] / tests / phpunit / WebTest / Case / CaseDashboardTest.php

diff --git a/tests/phpunit/WebTest/Case/CaseDashboardTest.php b/tests/phpunit/WebTest/Case/CaseDashboardTest.php
index 86d5d93bba9d072305e15d8beb7a3561440fdcbc..c8166af949a11c4635371b9a862ad4c7f898fb32 100644 (file)
--- a/tests/phpunit/WebTest/Case/CaseDashboardTest.php
+++ b/tests/phpunit/WebTest/Case/CaseDashboardTest.php
@@ -1,7 +1,7 @@
 <?php
 /*
  +--------------------------------------------------------------------+
- | CiviCRM version 4.5                                                |
+ | CiviCRM version 4.6                                                |
  +--------------------------------------------------------------------+
  | Copyright CiviCRM LLC (c) 2004-2014                                |
  +--------------------------------------------------------------------+
@@ -35,15 +35,20 @@ class WebTest_Case_CaseDashboardTest extends CiviSeleniumTestCase {
     parent::setUp();
   }
 
-  function testAllOrMyCases() {
+  public function testAllOrMyCases() {
     // Log in as admin first to verify permissions for CiviCase
-    $this->webtestLogin('true');
+    $this->webtestLogin('admin');
 
     // Enable CiviCase module if necessary
     $this->enableComponents("CiviCase");
 
     // let's give full CiviCase permissions to demo user (registered user).
-    $permission = array('edit-2-access-all-cases-and-activities', 'edit-2-access-my-cases-and-activities', 'edit-2-administer-civicase', 'edit-2-delete-in-civicase');
+    $permission = array(
+      'edit-2-access-all-cases-and-activities',
+      'edit-2-access-my-cases-and-activities',
+      'edit-2-administer-civicase',
+      'edit-2-delete-in-civicase'
+    );
     $this->changePermissions($permission);
 
     // Log in as normal user
@@ -71,14 +76,8 @@ class WebTest_Case_CaseDashboardTest extends CiviSeleniumTestCase {
     //Add case to get drilldown cell on Case dashboard
     $this->openCiviPage('case/add', 'reset=1&action=add&atype=13&context=standalone', '_qf_Case_upload-bottom');
 
-    // Adding contact with randomized first name (so we can then select that contact when creating case)
     // We're using pop-up New Contact dialog
-    $firstName = substr(sha1(rand()), 0, 7);
-    $lastName = "Fraser";
-    $contactName = "{$lastName}, {$firstName}";
-    $displayName = "{$firstName} {$lastName}";
-    $email = "{$lastName}.{$firstName}@example.org";
-    $this->webtestNewDialogContact($firstName, $lastName, $email, $type = 4, "s2id_client_id");
+    $this->createDialogContact('client_id');
 
     // Fill in other form values. We'll use a case type which is included in CiviCase sample data / xml files.
     $caseTypeLabel = "Adult Day Care Referral";
@@ -110,7 +109,7 @@ class WebTest_Case_CaseDashboardTest extends CiviSeleniumTestCase {
     $this->waitForText('crm-notification-container', "Case opened successfully.");
 
     // Go back to dashboard
-    $this->openCivipage('case', 'reset=1', 'css=a.button');
+    $this->openCiviPage('case', 'reset=1');
 
     // Click on a drilldown cell and check if right radio is checked
     $this->clickLink("css=a.crm-case-summary-drilldown", "css=input.crm-form-submit");
@@ -125,4 +124,3 @@ class WebTest_Case_CaseDashboardTest extends CiviSeleniumTestCase {
     $this->assertTrue($this->isChecked("name=case_owner value=2"), 'Drilldown on dashboard summary cells not properly setting search form value to my cases.');
   }
 }
-