Merge pull request #15884 from kainuk/issue-lab-1365

[civicrm-core.git] / tests / phpunit / CRM / Utils / DeprecatedUtilsTest.php

diff --git a/tests/phpunit/CRM/Utils/DeprecatedUtilsTest.php b/tests/phpunit/CRM/Utils/DeprecatedUtilsTest.php
index f1d5e348cdea7451f3b161151d96c196b0bf9eee..2cb51c4195224b1d36a2d8593762a4641ff4873a 100644 (file)
--- a/tests/phpunit/CRM/Utils/DeprecatedUtilsTest.php
+++ b/tests/phpunit/CRM/Utils/DeprecatedUtilsTest.php
@@ -1,10 +1,10 @@
 <?php
 
-require_once 'CiviTest/CiviUnitTestCase.php';
 require_once 'CRM/Utils/DeprecatedUtils.php';
 
 /**
  * Class CRM_Utils_DeprecatedUtilsTest
+ * @group headless
  */
 class CRM_Utils_DeprecatedUtilsTest extends CiviUnitTestCase {
 
@@ -14,12 +14,12 @@ class CRM_Utils_DeprecatedUtilsTest extends CiviUnitTestCase {
 
   public function tearDown() {
     // truncate a few tables
-    $tablesToTruncate = array(
+    $tablesToTruncate = [
       'civicrm_contact',
       'civicrm_email',
       'civicrm_contribution',
       'civicrm_website',
-    );
+    ];
 
     $this->quickCleanup($tablesToTruncate);
   }
@@ -28,70 +28,27 @@ class CRM_Utils_DeprecatedUtilsTest extends CiviUnitTestCase {
    *  Test civicrm_contact_check_params with no contact type.
    */
   public function testCheckParamsWithNoContactType() {
-    $params = array('foo' => 'bar');
+    $params = ['foo' => 'bar'];
     $contact = _civicrm_api3_deprecated_contact_check_params($params, FALSE);
-    $this->assertEquals(1, $contact['is_error'], "In line " . __LINE__);
-  }
-
-
-  /**
-   *  Test civicrm_contact_check_params with a duplicate.
-   */
-  public function testCheckParamsWithDuplicateContact() {
-    //  Insert a row in civicrm_contact creating individual contact
-    $op = new PHPUnit_Extensions_Database_Operation_Insert();
-    $op->execute($this->_dbconn,
-      $this->createXMLDataSet(
-        dirname(__FILE__) . '/../../api/v3/dataset/contact_17.xml'
-      )
-    );
-    $op->execute($this->_dbconn,
-      $this->createXMLDataSet(
-        dirname(__FILE__) . '/../../api/v3/dataset/email_contact_17.xml'
-      )
-    );
-
-    $params = array(
-      'first_name' => 'Test',
-      'last_name' => 'Contact',
-      'email' => 'TestContact@example.com',
-      'contact_type' => 'Individual',
-    );
-    $contact = _civicrm_api3_deprecated_contact_check_params($params, TRUE);
     $this->assertEquals(1, $contact['is_error']);
-    $this->assertRegexp("/matching contacts.*17/s",
-      CRM_Utils_Array::value('error_message', $contact)
-    );
   }
 
-
   /**
    *  Test civicrm_contact_check_params with a duplicate.
    *  and request the error in array format
    */
   public function testCheckParamsWithDuplicateContact2() {
-    //  Insert a row in civicrm_contact creating individual contact
-    $op = new PHPUnit_Extensions_Database_Operation_Insert();
-    $op->execute($this->_dbconn,
-      $this->createXMLDataSet(
-        dirname(__FILE__) . '/../../api/v3/dataset/contact_17.xml'
-      )
-    );
-    $op->execute($this->_dbconn,
-      $this->createXMLDataSet(
-        dirname(__FILE__) . '/../../api/v3/dataset/email_contact_17.xml'
-      )
-    );
+    $this->individualCreate(['first_name' => 'Test', 'last_name' => 'Contact', 'email' => 'TestContact@example.com']);
 
-    $params = array(
+    $params = [
       'first_name' => 'Test',
       'last_name' => 'Contact',
       'email' => 'TestContact@example.com',
       'contact_type' => 'Individual',
-    );
-    $contact = _civicrm_api3_deprecated_contact_check_params($params, TRUE, TRUE);
+    ];
+    $contact = _civicrm_api3_deprecated_contact_check_params($params, TRUE);
     $this->assertEquals(1, $contact['is_error']);
-    $this->assertRegexp("/matching contacts.*17/s",
+    $this->assertRegexp("/matching contacts.*1/s",
       $contact['error_message']['message']
     );
   }
@@ -101,9 +58,9 @@ class CRM_Utils_DeprecatedUtilsTest extends CiviUnitTestCase {
    *  params and no params
    */
   public function testCheckParamsWithNoParams() {
-    $params = array();
+    $params = [];
     $contact = _civicrm_api3_deprecated_contact_check_params($params, FALSE);
-    $this->assertEquals(1, $contact['is_error'], "In line " . __LINE__);
+    $this->assertEquals(1, $contact['is_error']);
   }
 
 }