Merge pull request #16447 from samuelsov/lab#1319

[civicrm-core.git] / tests / phpunit / CRM / Core / MenuTest.php

diff --git a/tests/phpunit/CRM/Core/MenuTest.php b/tests/phpunit/CRM/Core/MenuTest.php
index 1b6a7d311ae6eddbbf17c5dd84cffc2dfa95f812..b0cae399572d1347b36b8b6bdefb322cfa238b3c 100644 (file)
--- a/tests/phpunit/CRM/Core/MenuTest.php
+++ b/tests/phpunit/CRM/Core/MenuTest.php
@@ -21,7 +21,7 @@ class CRM_Core_MenuTest extends CiviUnitTestCase {
     </menu>
     ';
     $xml = simplexml_load_string($xmlString);
-    $menu = array();
+    $menu = [];
     CRM_Core_Menu::readXML($xml, $menu);
     $this->assertTrue(isset($menu['civicrm/foo/bar']));
     $this->assertEquals('Foo Bar', $menu['civicrm/foo/bar']['title']);
@@ -48,19 +48,23 @@ class CRM_Core_MenuTest extends CiviUnitTestCase {
     </menu>
     ';
     $xml = simplexml_load_string($xmlString);
-    $menu = array();
+    $menu = [];
     CRM_Core_Menu::readXML($xml, $menu);
     $this->assertTrue(isset($menu['civicrm/foo/bar']));
     $this->assertEquals('Foo Bar', $menu['civicrm/foo/bar']['title']);
-    $this->assertEquals(array('alpha', 'beta'), $menu['civicrm/foo/bar']['ids_arguments']['json']);
-    $this->assertEquals(array('gamma'), $menu['civicrm/foo/bar']['ids_arguments']['exceptions']);
-    $this->assertEquals(array(), $menu['civicrm/foo/bar']['ids_arguments']['html']);
+    $this->assertEquals(['alpha', 'beta'], $menu['civicrm/foo/bar']['ids_arguments']['json']);
+    $this->assertEquals(['gamma'], $menu['civicrm/foo/bar']['ids_arguments']['exceptions']);
+    $this->assertEquals([], $menu['civicrm/foo/bar']['ids_arguments']['html']);
 
     $idsConfig = CRM_Core_IDS::createRouteConfig($menu['civicrm/foo/bar']);
-    $this->assertTrue(in_array('alpha', $idsConfig['General']['json'])); // XML
-    $this->assertTrue(in_array('beta', $idsConfig['General']['json'])); // XML
-    $this->assertTrue(in_array('gamma', $idsConfig['General']['exceptions'])); // XML
-    $this->assertTrue(in_array('thankyou_text', $idsConfig['General']['exceptions'])); // Inherited
+    // XML
+    $this->assertTrue(in_array('alpha', $idsConfig['General']['json']));
+    // XML
+    $this->assertTrue(in_array('beta', $idsConfig['General']['json']));
+    // XML
+    $this->assertTrue(in_array('gamma', $idsConfig['General']['exceptions']));
+    // Inherited
+    $this->assertTrue(in_array('thankyou_text', $idsConfig['General']['exceptions']));
   }
 
   /**
@@ -73,7 +77,7 @@ class CRM_Core_MenuTest extends CiviUnitTestCase {
     $this->assertFalse(isset($item['ids_arguments']['exceptions']));
     $this->assertFalse(isset($item['whimsy']));
 
-    CRM_Utils_Hook::singleton()->setHook('civicrm_alterMenu', function(&$items){
+    CRM_Utils_Hook::singleton()->setHook('civicrm_alterMenu', function(&$items) {
       $items['civicrm/case']['ids_arguments']['exceptions'][] = 'foobar';
       $items['civicrm/case']['whimsy'] = 'godliness';
     });
@@ -88,37 +92,38 @@ class CRM_Core_MenuTest extends CiviUnitTestCase {
    * @return array
    */
   public function pathArguments() {
-    $cases = array(); // array(0 => string $input, 1 => array $expectedOutput)
+    // array(0 => string $input, 1 => array $expectedOutput)
+    $cases = [];
     //$cases[] = array(NULL, array());
     //$cases[] = array('', array());
     //$cases[] = array('freestanding', array('freestanding' => NULL));
-    $cases[] = array('addSequence=1', array('addSequence' => '1'));
-    $cases[] = array('attachUpload=1', array('attachUpload' => '1'));
-    $cases[] = array('mode=256', array('mode' => '256'));
-    $cases[] = array(
+    $cases[] = ['addSequence=1', ['addSequence' => '1']];
+    $cases[] = ['attachUpload=1', ['attachUpload' => '1']];
+    $cases[] = ['mode=256', ['mode' => '256']];
+    $cases[] = [
       'mode=256,addSequence=1,attachUpload=1',
-      array('mode' => '256', 'addSequence' => '1', 'attachUpload' => 1),
-    );
-    $cases[] = array(
+      ['mode' => '256', 'addSequence' => '1', 'attachUpload' => 1],
+    ];
+    $cases[] = [
       'mode=256,urlToSession=a:b:c:d',
-      array(
+      [
         'mode' => '256',
-        'urlToSession' => array(
-          array('urlVar' => 'a', 'sessionVar' => 'b', 'type' => 'c', 'default' => 'd'),
-        ),
-      ),
-    );
-    $cases[] = array(
+        'urlToSession' => [
+          ['urlVar' => 'a', 'sessionVar' => 'b', 'type' => 'c', 'default' => 'd'],
+        ],
+      ],
+    ];
+    $cases[] = [
       'mode=256,urlToSession=a:b:c:d;z:y:x:w',
-      array(
+      [
         'mode' => '256',
-        'urlToSession' => array(
-          array('urlVar' => 'a', 'sessionVar' => 'b', 'type' => 'c', 'default' => 'd'),
-          array('urlVar' => 'z', 'sessionVar' => 'y', 'type' => 'x', 'default' => 'w'),
-        ),
-      ),
-    );
-    $cases[] = array('url=whiz!;.:#=%/|+bang?', array('url' => 'whiz!;.:#=%/|+bang?'));
+        'urlToSession' => [
+          ['urlVar' => 'a', 'sessionVar' => 'b', 'type' => 'c', 'default' => 'd'],
+          ['urlVar' => 'z', 'sessionVar' => 'y', 'type' => 'x', 'default' => 'w'],
+        ],
+      ],
+    ];
+    $cases[] = ['url=whiz!;.:#=%/|+bang?', ['url' => 'whiz!;.:#=%/|+bang?']];
     return $cases;
   }