test failure fix2

[civicrm-core.git] / js / angular-crmCaseType.js

diff --git a/js/angular-crmCaseType.js b/js/angular-crmCaseType.js
index ea2ca50d48740ca70393d3534a642bf7b76ba7be..f8ae9551485c1dc873472ecf6a9b5ea8111264ab 100644 (file)
--- a/js/angular-crmCaseType.js
+++ b/js/angular-crmCaseType.js
@@ -1,10 +1,10 @@
 (function(angular, $, _) {
 
   var partialUrl = function(relPath) {
-    return CRM.resourceUrls['civicrm'] + '/partials/crmCaseType/' + relPath;
+    return CRM.resourceUrls.civicrm + '/partials/crmCaseType/' + relPath;
   };
 
-  var crmCaseType = angular.module('crmCaseType', ['ngRoute', 'ui.utils', 'crmUi', 'unsavedChanges']);
+  var crmCaseType = angular.module('crmCaseType', ['ngRoute', 'ui.utils', 'crmUi', 'unsavedChanges', 'crmUtil']);
 
   // Note: This template will be passed to cloneDeep(), so don't put any funny stuff in here!
   var newCaseTypeTemplate = {
@@ -128,6 +128,7 @@
 
   crmCaseType.controller('CaseTypeCtrl', function($scope, crmApi, apiCalls) {
     $scope.partialUrl = partialUrl;
+    var ts = $scope.ts = CRM.ts('CiviCase');
 
     $scope.activityStatuses = _.values(apiCalls.actStatuses.values);
     $scope.activityTypes = apiCalls.actTypes.values;
@@ -221,7 +222,7 @@
     };
 
     $scope.isForkable = function() {
-      return !$scope.caseType.id || $scope.caseType.is_forkable
+      return !$scope.caseType.id || $scope.caseType.is_forkable;
     };
 
     $scope.isNewActivitySetAllowed = function(workflow) {
@@ -229,9 +230,9 @@
         case 'timeline':
           return true;
         case 'sequence':
-          return 0 == _.where($scope.caseType.definition.activitySets, {sequence: '1'}).length;
+          return 0 === _.where($scope.caseType.definition.activitySets, {sequence: '1'}).length;
         default:
-          if (console && console.log) console.log('Denied access to unrecognized workflow: (' + workflow + ')');
+          CRM.console('warn', 'Denied access to unrecognized workflow: (' + workflow + ')');
           return false;
       }
     };
@@ -277,8 +278,8 @@
 
     $scope.save = function() {
       var result = crmApi('CaseType', 'create', $scope.caseType, true);
-      result.success(function(data) {
-        if (data.is_error == 0) {
+      result.then(function(data) {
+        if (data.is_error === 0 || data.is_error == '0') {
           $scope.caseType.id = data.id;
           window.location.href = '#/caseType';
         }
@@ -311,11 +312,9 @@
     $scope.toggleCaseType = function (caseType) {
       caseType.is_active = (caseType.is_active == '1') ? '0' : '1';
       crmApi('CaseType', 'create', caseType, true)
-        .then(function (data) {
-          if (data.is_error) {
-            caseType.is_active = (caseType.is_active == '1') ? '0' : '1'; // revert
-            $scope.$digest();
-          }
+        .catch(function (data) {
+          caseType.is_active = (caseType.is_active == '1') ? '0' : '1'; // revert
+          $scope.$digest();
         });
     };
     $scope.deleteCaseType = function (caseType) {
@@ -325,23 +324,19 @@
         }
       })
         .then(function (data) {
-          if (!data.is_error) {
-            delete caseTypes.values[caseType.id];
-            $scope.$digest();
-          }
+          delete caseTypes.values[caseType.id];
+          $scope.$digest();
         });
     };
     $scope.revertCaseType = function (caseType) {
       caseType.definition = 'null';
       caseType.is_forked = '0';
       crmApi('CaseType', 'create', caseType, true)
-        .then(function (data) {
-          if (data.is_error) {
-            caseType.is_forked = '1'; // restore
-            $scope.$digest();
-          }
+        .catch(function (data) {
+          caseType.is_forked = '1'; // restore
+          $scope.$digest();
         });
     };
   });
 
-})(angular, CRM.$, CRM._);
\ No newline at end of file
+})(angular, CRM.$, CRM._);