]);
foreach ($activities as &$activity) {
if (!empty($activity['case_id'])) {
- $case = CRM_Utils_Array::value($activity['case_id'][0], $cases['values']);
+ $case = $cases['values'][$activity['case_id'][0]] ?? NULL;
if ($case) {
foreach ($case as $key => $value) {
if ($key != 'id') {
$recordType = $typeMap[$activityContact['record_type_id']];
if (in_array($recordType, ['target', 'assignee'])) {
$activities[$activityContact['activity_id']][$recordType . '_contact_id'][] = $contactID;
- $activities[$activityContact['activity_id']][$recordType . '_contact_name'][$contactID] = isset($activityContact['contact_id.display_name']) ? $activityContact['contact_id.display_name'] : '';
- $activities[$activityContact['activity_id']][$recordType . '_contact_sort_name'][$contactID] = isset($activityContact['contact_id.sort_name']) ? $activityContact['contact_id.sort_name'] : '';
+ $activities[$activityContact['activity_id']][$recordType . '_contact_name'][$contactID] = $activityContact['contact_id.display_name'] ?? '';
+ $activities[$activityContact['activity_id']][$recordType . '_contact_sort_name'][$contactID] = $activityContact['contact_id.sort_name'] ?? '';
}
else {
$activities[$activityContact['activity_id']]['source_contact_id'] = $contactID;
- $activities[$activityContact['activity_id']]['source_contact_name'] = isset($activityContact['contact_id.display_name']) ? $activityContact['contact_id.display_name'] : '';
- $activities[$activityContact['activity_id']]['source_contact_sort_name'] = isset($activityContact['contact_id.sort_name']) ? $activityContact['contact_id.sort_name'] : '';
+ $activities[$activityContact['activity_id']]['source_contact_name'] = $activityContact['contact_id.display_name'] ?? '';
+ $activities[$activityContact['activity_id']]['source_contact_sort_name'] = $activityContact['contact_id.sort_name'] ?? '';
}
}
}
*/
function _civicrm_api3_activity_check_params(&$params) {
$activityIds = [
- 'activity' => CRM_Utils_Array::value('id', $params),
- 'parent' => CRM_Utils_Array::value('parent_id', $params),
- 'original' => CRM_Utils_Array::value('original_id', $params),
+ 'activity' => $params['id'] ?? NULL,
+ 'parent' => $params['parent_id'] ?? NULL,
+ 'original' => $params['original_id'] ?? NULL,
];
foreach ($activityIds as $id => $value) {
//correctly by doing pseudoconstant validation
// needs testing
$activityTypes = CRM_Activity_BAO_Activity::buildOptions('activity_type_id', 'validate');
- $activityName = CRM_Utils_Array::value('activity_name', $params);
+ $activityName = $params['activity_name'] ?? NULL;
$activityName = ucfirst($activityName);
- $activityLabel = CRM_Utils_Array::value('activity_label', $params);
+ $activityLabel = $params['activity_label'] ?? NULL;
if ($activityLabel) {
$activityTypes = CRM_Activity_BAO_Activity::buildOptions('activity_type_id', 'create');
}
- $activityTypeId = CRM_Utils_Array::value('activity_type_id', $params);
+ $activityTypeId = $params['activity_type_id'] ?? NULL;
if ($activityName || $activityLabel) {
$activityTypeIdInList = array_search(($activityName ? $activityName : $activityLabel), $activityTypes);